mapspage-dev #66

Merged

liquidwater0 merged 1 commits from mapspage-dev into staging 2025-04-03 06:24:26 +00:00

Conversation 2 Commits 1 Files Changed 3 +920

liquidwater0 commented 2025-04-03 06:19:01 +00:00

Contributor

Copy Link

maps page

maps page

liquidwater0 added 274 commits 2025-04-03 06:19:01 +00:00

web: remove Roblox.ts ae6e968135

script review: introduce None policy 346f49610d

openapi: GET /script-policy endpoint to list script policies 00fdbd9611

web: form page base concept e31dec6424

web: maybe /submit instead of /submission_new 203ae67384

openapi: list filter belongs in request body 673152bc0d

Add drone ci 5e5caae6c3

web: material ui form inputs on the submission page, "Target" radio buttons d4303612ac

validation: fs unneeded 76abcf0a34

validation: remove map publishing 1450c0f3a2

validation: pull out submissions api 4ce5d5e535

openapi: move internal functions to separate api spec cd9bb17370

openapi: public endpoints use cookieAuth by default 7a30dc4ec3

openapi: generate 95675c51e6

submissions: refactor publishing model 9e022ca265

roles: potential future roles 29b77f14de

openapi-internal: optionally change TargetAssetID on upload 47c30ad2db

submissions: update ActionSubmissionUploaded 7e940cdfb1

submissions-api: v0.1.1 7d2147779a

web: change buttons 75d8cafc7b

nats: edit PublishNewRequest message 33d272ab04

submissions-api-rs: v0.2.0 split internal & external cf1fdb4099

docker: split internal & external api ecbd102aef

docker: use env file because env var is broken 11846c32e6

docker: rename stuff for no reason ed68af80b0

submissions-api: v0.2.1 feature flag for external ce59d7c947

submissions: chatgpt solution 3cfcbff253

submissions: fix null pointer deref 2342981643

submissions-api: v0.2.2 wrong url in action_submission_uploaded ec414a0f42

validation: plumb group id into publish functions cb736628d7

submissions: chatgpt solution #2 9a7270d2f9

web: review buttons are no longer hard-coded for submission id 1 ffadaa44be

docker: use staging cookie and group 64e9e2b263

validation: upload new scripts 332578ec94

submissions: return 404 when ErrNotExist f4abc30c21

scripts: name property db52b1dcd4

validation: fix hash formatting 8c45736cf4

submissions: centralize hashing and formatting 6bab1e1b6b

submissions: fix unhandled error path causing silent failure 298a68fa97

submissions: wrong query 3a6dd311bf

submissions: comment on unclear status name 9bdf98635e

submissions: tweak comments 2ad219cf77

openapi: legendary levels of duplicate code e46f9fc6ea

openapi: generate 7ad4ffc7e0

submissions: legendary code duplication 7a7e158ec3

submissions: UpdateSubmissionModel internal endpoint ... 67651633d8

not quite duplicate code, hooray

validation: subsume submissions-api 833ed66844

validation: use path f3af65aa13

validation: api is internal only f7101e2b84

docker: internal only + path copy b5bb79c6ef

sumbissions: return correct http error code 185a1d147f

openapi: no minimum length for script names 49db6e35ce

openapi: generate 299f994f32

submissions-api: use goofy function to make errors include more information e7234a614d

submissions-api: hardcode header to application/json 6064a1e48f

docker: .dockerignore 3ea881e724

submissions-api: need stupid dependency to do this 0dc39121c8

validation: set status on failure 9070d77f41

openapi: remove required ID field on Filter schemas fe0a1e0e0f

openapi: generate a28ec58ce8

openapi: make pagination match game-rpc 6545fa703d

openapi: generate 1d3e553390

submissions: update openapi b238e4c21d

submissions: fix list requests e905d96917

openapi: flatten list query parameters 88dfc92bc6

openapi: generate 76d36bea5c

submissions: flatten list query params a94ae5d61e

submissions-api: optional cookie 964fc24e26

submissions-api: reintroduce external api 518327820d

openapi: normalize get policy from hash as list request 6a8805b91a

openapi: generate 516bd7a439

submissions: normalize get from hash as list requests 621edbdbe0

validation: update api 246b8a7dc8

submissions-api: add eq to select types b782b1ae64

submissions-api: silence lint 8dbb4517fa

submissions-api: v0.3.0 refactor 02d77ab421

Huge mess 9bd3eb69f9

compilable:) b0b16c91dc

web: fix up ... a7e9dbb94d

When possible you should not use inline styling and instead use SCSS files for following convention and keeping consistency, Grid is also a deprecated React component in Material UI
You should also separate components that are client only to its own .tsx module rather than having it be mixed with components that aren't required for being client only

submissions-api: fix cookie b3ffbe4b50

submissions: postgres does not support unsigned integers, so let's pretend they are signed f04ab4f653

bruh a511246d78

submissions-api: openapi expects optional fields to be omitted ... ca846972c1

The default serde configuration is to serialize optional values as "null"

validation: flag illegal keywords a45b4f2f0c

submissions-api: lazily export other error to avoid importing reqwest elsewhere 8b3aa158c9

submissions-api: wrong url f038b9cda6

submissions-api: incorrectly named field 25dbc038ca

submissions: implement ScriptWrite permission c085ea9b7d

web: remove maptest button cd57ead995

web: describe when each button should be visible 1b58bfd096

TEMP: validation: force model upload to prevent model validation bait and switch 0d549a46d4

submissions: refactor auth to only make requests when needed 8bf2c92df3

submissions: limit active submissions to 20 07ef22bc02

web: submission page reload after action request completes f629ac2998

web: submit page navigates to newly created submission d584ee2c03

web: fix status codes 56ff5670dd

web: display model id 78db4eeba7

web: submit TargetAssetID 94abe3137b

web: submit GameID c95d10a0d4

submissions: reject duplicate submissions ... c04ba33f9c

closes #6

openapi: add release-submissions endpoint bc8b7b68d2

openapi: generate 0794e7ba46

submissions: connect to maps grpc 952b77b3db

submissions: ReleaseSubmissions operation 952ceab014

docker: update compose ca1e007b07

openapi-internal: remove unused endpoint e43f4bd0f0

small changes 040488d85f

openapi: add sort parameter to listSubmissions 8e223d432e

openapi: generate a39e2892ef

submissions: implement sort functionality for listSubmissions 28990e2dbe

document environment variables 8dbdfbdb3f

middleware 75e8d2b7b2

document the middleware b6c7c76900

middleware: oops, thats the wrong path a82a78c938

Strip /api prefix 59e5e529c6

submissions: modernize loops 8338a71470

openapi: no security for get submission requests 11e801443f

openapi: generate 91a72ccf8b

web: note when submissions list is loaded but empty 49e767f027

validation: use cargo workspace e1645e7c46

validation: explicitly append url (TODO: update deployment env var) ecb88c14a4

submissions-api: external is default usage 57544f3f64

submissions-api: v0.4.0 1341f87bf8

validation: v0.1.1 f5c4868dc4

submissions: add ValidatedModelID to submissions model b542dba739

openapi: internal operation updates validated model 47129e2d1f

openapi: generate d77bf02185

submissions: implement internal validated model 57d714fdd7

submissions-api: validated-model 99e320d17f

submissions-api: v0.5.0 e5a1dcf144

submissions: publish validated model 355161c3b1

Revert "openapi: no security for get submission requests" ... e66513e88d

This reverts commit 11e801443f.

openapi: generate 80e7d735be

submissions: tweak group roles to allow developers proper staging permissions c6b31b7c73

openapi: add status message to validation failure 0271ba4d28

openapi: generate ff01abdd63

submissions: add StatusMessage to submissions 483ffd1d66

submissions-api: add status message to validation failure 0c247fbb43

submissions-api: v0.6.0 b496f8c0d8

web: display validation error b377405762

submissions: implement reset from softlock 31f1db6446

openapi: implement reset from softlock 0b1e7085e3

openapi: generate f52e0a91a2

web: implement reset from softlock b4be174d98

submissions: reject reset unless validator is stale 73e5c76e75

submissions: submitter cannot accept their own submission 6748cb4324

Enable auto deploy 08a4e913a9

web: throw error on failure status (#16) ... 3da4023466

Thanks to ai for knowing javascript

Co-authored-by: rhpidfyre <brandon@rhpidfyre.io>
Reviewed-on: #16
Co-authored-by: Quaternions <krakow20@gmail.com>
Co-committed-by: Quaternions <krakow20@gmail.com>

openapi: fix operation summary 894851c0e8

openapi: add session endpoints 8da1c9346b

openapi: generate d7634de9ec

submissions: rename UserInfo to UserInfoHandle 977d1d20c2

submissions: refactor roles 783d0e843c

submissions: add UserInfoHandle.GetUserInfo function 7213948a26

submissions: add UserInfoHandle.Validate 1feca92f7d

submissions: implement session endpoints 1af7d7e941

submissions: refactor roles again d16bb8ad02

fix docker compose 6af006f802

submissions: refactor UserInfoHandle.GetRoles 295ec3cd8b

submissions: fix roles bug 636bb1fb94

submissions: improve error granularity 7d57d1ac4d

submissions: rename SubmissionPublish to SubmissionUpload 87fd7adb93

validator: correct enum item name 539e09fe06

submissions: introduce new role SubmissionRelease a8dc6cd35a

docker: use staging auth image 65e63431a3

docker: add group id env var bf6c8af21a

docker: fix API_HOST 5ae287f3f2

validation: do not implicitly append url 4fec1bba47

openapi: include status message f0c44fb4a8

openapi: generate 7cc0b5da7f

submissions: include status message 039309c75a

web: redirect if the user is not logged in based on session_id cookie's presence d5d0e5ffc9

web: use --turbopack for dev 936a1f93aa

submissions-api: derive Clone, Debug on many types 1ca0348924

submissions-api: include get_scripts & get_script_from_hash in internal api ce08b57e18

validator: refactor errors to improve information and clarity cd82954b73

validator: write and use tragic script name function 123bc8af47

validator: name model correctly 4227f18992

submissions-api: v0.6.1 85a144e276

submissions: detect sentinel value 2867da4b21

openapi: rename field 1053719eab

openapi: generate 1468a9edc2

submissions: rename VersionID to ValidatedModelVersion 188fbd2a6d

validation: include script path in ScriptFlaggedIllegalKeyword d3edb6b3da

web: auth redirect fix a9afdf38cf

web: Revert auth redirect 251a24efae

openapi: opt out of security for get requests 032f0e8739

openapi: generate 79c21b62d8

submissions: do not validate session in HandleCookieAuth c8077482f3

openapi: user session is required for SessionValidate a7c72163eb

openapi: generate 2f2241612a

Switch to using /api/session/validate for determining if the user is not logged in (#34) ... b02b3d205e

My apologies for being stupid not knowing the NextJS framework fully, as I have little experience with it and its non intuitive SSR and CSR workflow

Code successfully built locally running `bun run build`

Reviewed-on: #34
Co-authored-by: rhpidfyre <brandon@rhpidfyre.io>
Co-committed-by: rhpidfyre <brandon@rhpidfyre.io>

validation: refactor get_partial_path af9f413b49

openapi: split trigger-validate into two cases 977f3902b7

openapi: generate e7a66ebe0d

submissions: remove Accepted from valid src status in ActionSubmissionTriggerValidate cc1d5f4bda

submissions: implement ActionSubmissionRetryValidate 661fa17fa7

web: Validate button calls retry-validate endpoint f0e18a5963

web: fix api types a7784bdaf5

submissions: add AcceptedBy, UploadedBy fields to model 4c17a3c9e9

submissions: log accepter and uploader 49fea314ec

validation: update deps 6e21447d4b

rename part 1: move files e855ace229

rename part 2: rename all occurrences of "publish" to "upload" f3689f4916

submissions: remove StatusUploaded from ActiveSubmissionStatuses 2c75cfa67f

submissions: move pipeline restriction to accept rather than create f2d8c49647

submissions: typo in error variable names 4515eb6da2

submissions: allow map council to upload maps 92226e768d

Revert "submissions: add AcceptedBy, UploadedBy fields to model" ... 88c3866654

This reverts commit 4c17a3c9e9.

submissions: prepare for separate mapfixes dfc2a605f4

openapi: tweak Submission fields 2d2691b551

openapi: generate 9740cbe91a

web: remove TargetAssetID 0e29ca98dd

openapi-internal: tweak validator-uploaded endpoint 0b64440975

openapi-internal: generate e5e85db1fd

submissions: tweak validator-uploaded endpoint f7d7a0891d

submissions: remove prints a60ccd22f0

validation: tweak validator-uploaded endpoint ffcba57408

nats: rename events 3404251c14

submissions: ruin script data model 9671c357f4

openapi: tweak script data model 930eb47096

openapi: generate 746c7aa9b7

submissions: tweak script data model 8366b84d90

validator: move files 01785bb190

validator: refactor + remove mapfix capability ade54ee662

submissions-api: create new error variant 758c2254eb

openapi: fix /scripts endpoint 4e22933e34

openapi: generate 581c65594d

openapi: missing fields a048d713da

openapi: generate 8de5bcba68

submissions: fix compile 8925d71bcd

web: fix SubmissionInfo type b0f1e42a06

nats: rename types 1d7f6ea79a

submissions: datastore: duplicate submissions as mapfixes e36b49a31e

openapi: mapfixes 2e65d071e0

openapi: generate 6d420c3a82

submissions: mapfixes 732598266c

submissions-api: deduplicate simple endpoints with crazy macro cc7df064be

submissions-api: add simple mapfixes endpoints 9dd7a41d8f

validator: add mapfix capability 96ace736f4

openapi: reintroduce mapfix fields b6ae600a93

openapi: generate de8f869b5b

submissions: reintroduce mapfix fields 37560ac5d2

web: clone submissions page for mapfixes 97180ab263

web: mapfixes: rename all occurrences of submission with mapfix 146d627534

web: add submit page at /maps/[mapId]/fix 4cf7889db9

web: change submit text to match mapfix submit page a119c4292e

submissions: fix mapfixes auto migrate c401d24366

submissions: refine roles 3bda4803aa

openapi: maps endpoints 082c573ffb

openapi: generate bfd287f3cc

submissions: maps endpoints e9f79241f1

model/user thumbnails 8a28d6cfcf

Merge pull request 'Change the map thumbnails to use the roblox api' (#64) from thumbnails into staging ... e877ba4788

Reviewed-on: #64
Reviewed-by: Quaternions <quaternions@noreply@itzana.me>

web: remove all fields from submission forms except Asset ID df39101102

openapi: long-running operations 722ac5178f

openapi: generate 493c6d084a

submissions: naively implement operations 508d41506a

openapi: move create endpoints to internal 34d37d8c1c

openapi: generate 56dec20189

submissions: trigger validator to create submissions & mapfixes 19c4e36990

submissions: implement internal submission create d4e8edbb6e

submissions: deny mapfix targeting nonexistent map a72be13843

openapi: internal operation failed endpoint 577ab5cdd0

openapi: generate 5aa27c08a5

submissions: implement operation failed internal endpoint a639b81988

validator: refactor again abed5c6227

validator: rename errors e466af7d27

submissions-api: add create internal endpoints 8776936e96

validator: implement create operations 3699ce5cbb

submissions-api: add operation failed endpoint 2c31a9585b

validator: report operation failure 0462788c53

web: add mapfixes link to header e85e3f130f

add routes for maps page adaa088efe

liquidwater0 changed target branch from master to staging 2025-04-03 06:21:10 +00:00

Quaternions commented 2025-04-03 06:21:59 +00:00

Owner

Copy Link

@interpreterK Note that this includes web/bun.lock

@interpreterK Note that this includes `web/bun.lock`

Quaternions approved these changes 2025-04-03 06:22:18 +00:00

liquidwater0 merged commit adaa088efe into staging 2025-04-03 06:24:26 +00:00

Quaternions deleted branch mapspage-dev 2025-04-03 06:29:31 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Quaternions

Labels

Clear labels

backend

Submissions api related

bug

Something is not working

duplicate

This issue or pull request already exists

enhancement

New feature

frontend

Website related

help wanted

Need some help

invalid

Something is wrong

question

More information is needed

validator

Map validation related

wontfix

This won't be fixed

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

aidan9382 CI dowoge ic3w0lf22 interpreterK itzaname Quaternions

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: StrafesNET/maps-service#66