submissions: refactor UserInfoHandle.GetRoles

pkg/service/security.go

@@ -103,22 +103,22 @@ func (usr UserInfoHandle) GetRoles() (Roles, error) {
 		SessionID: usr.sessionId,
 	})
 
-	var rolesBitflag = RolesEmpty;
 	if err != nil {
-		return rolesBitflag, err
+		return RolesEmpty, err
 	}
 
 	// map roles into bitflag
+	rolesBitflag := RolesEmpty;
 	for _, r := range roles.Roles {
 		switch GroupRole(r.Rank){
-			case RoleQuat:
-				rolesBitflag|=RolesQuat;
-			case RoleMapAdmin:
-				rolesBitflag|=RolesMapAdmin;
-			case RoleMapCouncil:
-				rolesBitflag|=RolesMapCouncil;
-			case RoleMapAccess:
-				rolesBitflag|=RolesMapAccess;
+		case RoleQuat:
+			rolesBitflag|=RolesQuat
+		case RoleMapAdmin:
+			rolesBitflag|=RolesMapAdmin
+		case RoleMapCouncil:
+			rolesBitflag|=RolesMapCouncil
+		case RoleMapAccess:
+			rolesBitflag|=RolesMapAccess
 		}
 	}
 	return rolesBitflag, nil