StrafesNET/strafe-project
7
Fork 4
Code Issues 8 Pull Requests 1 Packages Projects Releases 2 Wiki Activity

Ensure collisions are prioritised by model id instead of psuedo-random hashmap ordering #20

Merged
Quaternions merged 2 commits from aidan9382/strafe-project:consistent-collision-order into master 2025-11-18 19:42:14 +00:00
Conversation 1 Commits 2 Files Changed 1 +27 -9
aidan9382 commented 2025-11-18 19:28:22 +00:00
Member
Copy Link

Fixes #17

Fixes #17
aidan9382 added 2 commits 2025-11-18 19:28:23 +00:00
Ensure the PhysicsData's bvh respects the original model ordering 255bed4803 
There's no importance in worrying about the core HashMap ordering since it's not used as an iterator except for outside of this very function for bvh purposes
Use a From implementation instead of manual conversion 49c0c16e35 
If the contacts and intersects map ever change in the future to not be 1:1 with gaps but instead something else, this guarantees that this implicit use of the relationship will flag at a compiler level
Quaternions approved these changes 2025-11-18 19:41:51 +00:00
Quaternions left a comment
Owner
Copy Link

Elegant and minimal, great work

Elegant and minimal, great work
Quaternions merged commit 49c0c16e35 into master 2025-11-18 19:42:14 +00:00
aidan9382 deleted branch consistent-collision-order 2025-11-18 20:21:33 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Quaternions
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
AxisAngles CI itzaname Quaternions
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: StrafesNET/strafe-project#20
Delete Branch "aidan9382/strafe-project:consistent-collision-order"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?