StrafesNET/strafe-client
5
Fork 4
Code Issues 2 Pull Requests 1 Packages Projects Releases 1 Wiki Activity

Linux application support (.desktop) and AUR pkgbuild script #1

Closed
interpreterK wants to merge 2 commits from interpreterK/strafe-client:pkgbuild into master
pull from: interpreterK/strafe-client:pkgbuild
merge into: StrafesNET:master
Conversation 5 Commits 2 Files Changed 10 +40
interpreterK commented 2023-09-09 19:29:17 +00:00
First-time contributor
Copy Link

Will look more into .ico file type but probably best to support all possible locations for app icons and specifications listed by freedesktop and Arch Wiki, PKGBUILD was rewrote to pull from the master branch.

Will look more into .ico file type but probably best to support all possible locations for app icons and specifications listed by freedesktop and Arch Wiki, PKGBUILD was rewrote to pull from the master branch.
interpreterK added 2 commits 2023-09-09 19:29:17 +00:00
Quaternions commented 2023-09-09 19:57:30 +00:00
Owner
Copy Link

Do applications really need 10 different sizes of PNG? Can't they be combined into a single .ico file?

Do applications really need 10 different sizes of PNG? Can't they be combined into a single .ico file?
Quaternions commented 2023-09-09 20:52:18 +00:00
Owner
Copy Link

Also it seems kind of recursive to include the PKGBUILD in the project itself. This should probably live on AUR or it's own repo if you don't want to put it on AUR.

Also it seems kind of recursive to include the PKGBUILD in the project itself. This should probably live on AUR or it's own repo if you don't want to put it on AUR.
itzaname commented 2023-09-09 21:04:08 +00:00
Owner
Copy Link

image

![image](/attachments/128b132c-e7b3-4ef0-a452-c777225d4002)
image.png
101 KiB
interpreterK commented 2023-09-09 21:22:00 +00:00
Author
First-time contributor
Copy Link

Also it seems kind of recursive to include the PKGBUILD in the project itself. This should probably live on AUR or it's own repo if you don't want to put it on AUR.

I wasn't intending to include the PKGBUILD script at first but I later decided to add it so it's available for edits by mainly you. It cannot be recursively called unless the uploaded AUR PKGBUILD script calls this repo's PKGBUILD which will cause recursion, neither PKGBUILD scripts will call a new makepkg instance.

> Also it seems kind of recursive to include the PKGBUILD in the project itself. This should probably live on AUR or it's own repo if you don't want to put it on AUR. I wasn't intending to include the PKGBUILD script at first but I later decided to add it so it's available for edits by mainly you. It cannot be recursively called unless the uploaded AUR PKGBUILD script calls this repo's PKGBUILD which will cause recursion, neither PKGBUILD scripts will call a new makepkg instance.
interpreterK commented 2023-09-25 01:20:01 +00:00
Author
First-time contributor
Copy Link

Closing

Closing
interpreterK closed this pull request 2023-09-25 01:20:01 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: StrafesNET/strafe-client#1
No description provided.
Delete Branch "interpreterK/strafe-client:pkgbuild"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?