add flytrials #4
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "staging"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I've never coded in javascript so review my untested code thanks
3213bfdd91
to5681e21fbe
@ -4,0 +7,4 @@
deathrun: "files/deathrun_submissions.csv",
flytrials: "files/flytrials_submissions.csv",
};
var commandChoices = [];
use const instead of var
@ -4,0 +8,4 @@
flytrials: "files/flytrials_submissions.csv",
};
var commandChoices = [];
for (const [game, file] of Object.entries(gameDict)) {
I would use Object.keys rather than Object.entries since you aren't using the values
@ -10,3 +18,1 @@
else if (game === "surf") fname = "files/surf_submissions.csv";
else if (game === "deathrun") fname = "files/deathrun_submissions.csv";
else {
let fname = gameDict[game];
should be const fname rather than let fname since it won't be reassigned now
@ -11,2 +18,2 @@
else if (game === "deathrun") fname = "files/deathrun_submissions.csv";
else {
let fname = gameDict[game];
if (fname === undefined) {
if (!fname) is probably a bit more straightforward
@ -6,0 +9,4 @@
deathrun: "files/deathrun_submissions.csv",
flytrials: "files/flytrials_submissions.csv",
};
var commandChoices = [];
any changes need to be applied to each file. would probably be possible to make a new file and move the duplicate code there but not a big deal
doing this now
did this on my phone, only suggestions are just code style
5681e21fbe
to8fa05099be
I've incorporated most of the suggestions but redid the whole thing to use a centralized module. I hope I wrote the module export stuff correctly
8fa05099be
to770118d937
Looks good
770118d937
toace8e05b67
ace8e05b67
tob44dd98976