StrafesNET/maptest-bot
3
Fork 0
Code Issues Pull Requests Releases Activity

Log errors to a channel and also fix/improve error handling #16

Merged
itzaname merged 1 commits from log-errors-to-channel into master 2024-04-26 00:15:00 +00:00
Conversation 0 Commits 1 Files Changed 7 +95 -52
fiveman1 commented 2024-04-25 17:43:57 +00:00
Collaborator
Copy Link

Fixes:

  • If an error happened after the bot replied or deferred a reply, it would not tell you that an error occured, and instead nothing would happen. Now it will properly tell you that an error happened.

Enhancements:

  • If an error happens, we will log the error and the trace to a (private) channel I added in rbhop called #error-logs.
  • The bot now always does deferReply before every command which shows the "bot is thinking...".
  • The bot no longer does ephemeral replies since if you set deferReply to not be ephermal, you can edit it with an ephemeral response.
  • Improved some of the edge case handling about whether a model exists/is distributed/etc.
Fixes: - If an error happened after the bot replied or deferred a reply, it would not tell you that an error occured, and instead nothing would happen. Now it will properly tell you that an error happened. Enhancements: - If an error happens, we will log the error and the trace to a (private) channel I added in rbhop called #error-logs. - The bot now always does deferReply before every command which shows the "bot is thinking...". - The bot no longer does ephemeral replies since if you set deferReply to not be ephermal, you can edit it with an ephemeral response. - Improved some of the edge case handling about whether a model exists/is distributed/etc.
fiveman1 added 1 commit 2024-04-25 17:43:58 +00:00
itzaname requested review from itzaname 2024-04-26 00:13:30 +00:00
itzaname requested review from Quaternions 2024-04-26 00:13:30 +00:00
fiveman1 was assigned by itzaname 2024-04-26 00:13:43 +00:00
itzaname merged commit e27d6e5b70 into master 2024-04-26 00:15:00 +00:00
itzaname deleted branch log-errors-to-channel 2024-04-26 00:15:00 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
itzaname
Quaternions
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
fiveman1
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: StrafesNET/maptest-bot#16
No description provided.
Delete Branch "log-errors-to-channel"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?