StrafesNET/maps-service
5
Fork 4
Code Issues 17 Pull Requests 1 Packages Projects Releases Wiki Activity

Add SNFM download endpoints and batch seed endpoint #328

Merged
itzaname merged 5 commits from staging into master 2026-03-02 02:39:42 +00:00
Conversation 2 Commits 5 Files Changed 33 +1532 -200
itzaname commented 2026-03-01 22:49:20 +00:00
Owner
Copy Link

Adds download endpoint to RPC and Public API
Adds bulk seed endpoint: POST /v1/maps-admin/seed-combobulator

Adds download endpoint to RPC and Public API Adds bulk seed endpoint: POST /v1/maps-admin/seed-combobulator
itzaname self-assigned this 2026-03-01 22:49:20 +00:00
itzaname added 4 commits 2026-03-01 22:49:20 +00:00
Add snfm download endpoints
All checks were successful
continuous-integration/drone/push Build is passing
Details
c788344bf3
Doc updates
All checks were successful
continuous-integration/drone/push Build is passing
Details
0e2ffcd570
Just use normal asset download
All checks were successful
continuous-integration/drone/push Build is passing
Details
02873e82b6
Add map seed endpoint
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
078a3e4c4a
itzaname requested review from Quaternions 2026-03-01 22:49:20 +00:00
itzaname changed title from Add SNFM download endpoints and back seed endpoint to Add SNFM download endpoints and batch seed endpoint 2026-03-01 22:49:28 +00:00
Quaternions requested changes 2026-03-02 00:50:01 +00:00
Dismissed
pkg/public_api/dto/map.go Outdated
@@ -24,6 +24,10 @@ type Map struct {
Modes uint32 `json:"modes"`
} // @name Map
type SnfmDownloadUrl struct {
Quaternions commented 2026-03-02 00:46:21 +00:00
Owner
Copy Link

This is unused.

This is unused.
itzaname marked this conversation as resolved
pkg/public_api/handlers/maps.go
@@ -84,0 +90,4 @@
// @Failure 404 {object} dto.Error "Map not found"
// @Failure default {object} dto.Error "General error response"
// @Router /map/{id}/snfm [get]
func (h *MapHandler) GetSnfmDownloadUrl(ctx *gin.Context) {
Quaternions commented 2026-03-02 00:47:28 +00:00
Owner
Copy Link

What's the reason to use 302 on public-api bot download but 307 on map download endpoint?

What's the reason to use 302 on public-api bot download but 307 on map download endpoint?
itzaname commented 2026-03-02 01:07:10 +00:00
Author
Owner
Copy Link

It doesn't make a functional difference beyond some nuances that are not relevant here.

It doesn't make a functional difference beyond some nuances that are not relevant here.
Quaternions marked this conversation as resolved
itzaname added 1 commit 2026-03-02 01:11:25 +00:00
Remove unused struct
Some checks failed
continuous-integration/drone/pr Build is failing
Details
continuous-integration/drone/push Build is passing
Details
501b0933e6
Quaternions approved these changes 2026-03-02 01:19:22 +00:00
itzaname merged commit d4e50c2d37 into master 2026-03-02 02:39:42 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Quaternions
Labels
Clear labels
backend
Submissions api related
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 frontend
Website related
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 validator
Map validation related
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aidan9382 CI dowoge fiveman1 ic3w0lf22 interpreterK itzaname Quaternions
No Assignees itzaname
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: StrafesNET/maps-service#328
Delete Branch "staging"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?