StrafesNET/maps-service
4
Fork 4
Code Issues 20 Pull Requests 2 Packages Projects Releases Wiki Activity

Add mapfix history on maps page #294

Merged
itzaname merged 2 commits from feature/mapfix-list into staging 2025-12-27 04:51:04 +00:00
Conversation 2 Commits 2 Files Changed 2 +290 -39
itzaname commented 2025-12-27 01:41:35 +00:00
Owner
Copy Link

If map fixes exist for a map they will be displayed under the map image. Active map fixes were moved to be in this new element as well.

image.png
image.png
image.png

If map fixes exist for a map they will be displayed under the map image. Active map fixes were moved to be in this new element as well. ![image.png](/attachments/012e1055-3aba-40a4-97fe-e59d2ff9fb51) ![image.png](/attachments/d6c0e3b9-2578-4cd5-b15e-e2861c73819e) ![image.png](/attachments/cbec73a6-3f3d-48b6-bc14-18659b6aa94f)
image.png
506 KiB
image.png
469 KiB
image.png
491 KiB
itzaname added the frontend label 2025-12-27 01:41:35 +00:00
itzaname added 2 commits 2025-12-27 01:41:35 +00:00
Add mapfix history on maps page
All checks were successful
continuous-integration/drone/push Build is passing
Details
a19bc4d380
Just exclude rejected and released for active list
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
01cfe67848
itzaname requested review from Quaternions 2025-12-27 01:41:35 +00:00
itzaname commented 2025-12-27 01:41:54 +00:00
Author
Owner
Copy Link

Closes !235

Closes !235
Quaternions requested changes 2025-12-27 02:00:09 +00:00
Dismissed
web/src/app/maps/[mapId]/page.tsx
@@ -358,0 +378,4 @@
{/* Mapfix Section - Active + History */}
{mapfixes.length > 0 && (() => {
const activeFix = mapfixes.find(fix => fix.StatusID !== MapfixStatus.Rejected && fix.StatusID !== MapfixStatus.Released);
Quaternions commented 2025-12-27 01:55:25 +00:00
Owner
Copy Link

Mapfixes UnderConstruction should not be considered active. ChangesRequested is debatable, but I would consider "active" to mean "requires staff attention", i.e. attention from someone who is not the map fixer.

const activeFix = mapfixes.find(fix => fix.StatusID !== MapfixStatus.Rejected && fix.StatusID !== MapfixStatus.Released && fix.StatusID !== MapfixStatus.UnderConstruction && fix.StatusID !== MapfixStatus.ChangesRequested);
Mapfixes UnderConstruction should not be considered active. ChangesRequested is debatable, but I would consider "active" to mean "requires staff attention", i.e. attention from someone who is not the map fixer. ```js const activeFix = mapfixes.find(fix => fix.StatusID !== MapfixStatus.Rejected && fix.StatusID !== MapfixStatus.Released && fix.StatusID !== MapfixStatus.UnderConstruction && fix.StatusID !== MapfixStatus.ChangesRequested); ```
itzaname commented 2025-12-27 02:44:56 +00:00
Author
Owner
Copy Link

So the existing implementation was incorrect?

So the existing implementation was incorrect?
Quaternions commented 2025-12-27 02:57:56 +00:00
Owner
Copy Link

Yes, it was incorrect. Submitting another mapfix is blocked if there is an active mapfix. This is the list of statuses which are considered "active":

maps-service/pkg/web_api/mapfixes.go Lines 23 to 31 in ae006565d6
// limit mapfixes in the pipeline to one per target map
ActiveAcceptedMapfixStatuses = []model.MapfixStatus{
model.MapfixStatusReleasing,
model.MapfixStatusUploaded,
model.MapfixStatusUploading,
model.MapfixStatusValidated,
model.MapfixStatusValidating,
model.MapfixStatusAcceptedUnvalidated,
}

Note that this list does not include fixes that are Under Review (MapfixStatus.Submitted), so multiple mapfixes for the same map may be submitted at the same time, but not accepted at the same time.

I think it would be useful to include submitted mapfixes (MapfixStatus.Submitted) in this list in case the submitter is about to duplicate an effort that is already submitted.

Yes, it was incorrect. Submitting another mapfix is blocked if there is an active mapfix. This is the list of statuses which are considered "active": https://git.itzana.me/StrafesNET/maps-service/src/commit/ae006565d689a4829cde53a274869caf54e34323/pkg/web_api/mapfixes.go#L23-L31 Note that this list does not include fixes that are Under Review (MapfixStatus.Submitted), so multiple mapfixes for the same map may be submitted at the same time, but not accepted at the same time. I think it would be useful to include submitted mapfixes (MapfixStatus.Submitted) in this list in case the submitter is about to duplicate an effort that is already submitted.
Quaternions commented 2025-12-27 04:17:19 +00:00
Owner
Copy Link

I can fix it later since it was already like that.

I can fix it later since it was already like that.
Quaternions marked this conversation as resolved
web/src/app/ts/Mapfix.ts
@@ -69,0 +72,4 @@
iconName: string;
}
function getMapfixStatusInfo(statusId: MapfixStatus): MapfixStatusInfo {
Quaternions commented 2025-12-27 01:59:31 +00:00
Owner
Copy Link

Isn't this info duplicated for the status icon on the mapfix page?

Isn't this info duplicated for the status icon on the mapfix page?
itzaname commented 2025-12-27 02:47:47 +00:00
Author
Owner
Copy Link

That's why it's in a central importable lib instead of embedded into the page. Hunting down all duplication of this is not in scope for the feature. In the future this can be used instead.

That's why it's in a central importable lib instead of embedded into the page. Hunting down all duplication of this is not in scope for the feature. In the future this can be used instead.
👍 1
Quaternions marked this conversation as resolved
Quaternions approved these changes 2025-12-27 04:17:33 +00:00
itzaname merged commit efeb525e19 into staging 2025-12-27 04:51:04 +00:00
itzaname deleted branch feature/mapfix-list 2025-12-27 04:51:04 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Quaternions
Labels
Clear labels
backend
Submissions api related
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 frontend
Website related
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 validator
Map validation related
 wontfix
This won't be fixed
No Label frontend
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aidan9382 CI dowoge ic3w0lf22 interpreterK itzaname Quaternions
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: StrafesNET/maps-service#294
Delete Branch "feature/mapfix-list"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?