StrafesNET/maps-service
4
Fork 4
Code Issues 19 Pull Requests 1 Packages Projects Releases Wiki Activity

Public API #253

Merged
Quaternions merged 11 commits from public-api into staging 2025-08-06 06:07:12 +00:00
Conversation 4 Commits 11 Files Changed 13 +1378 -40
Quaternions commented 2025-08-06 01:29:41 +00:00
Owner
Copy Link

Closes #229

This is a MVP and only includes maps.

Closes #229 This is a MVP and only includes maps.
Quaternions added 8 commits 2025-08-06 01:29:41 +00:00
paste in public-api 16f5aae1a9
paste missing docs 71b8d02a9e
happy code e997155659
add swaggo swag docs comment a9b85cda96
add swag generate to generate.go d5065c22c0
swagger: generate
All checks were successful
continuous-integration/drone/push Build is passing
Details
725a1dd174
use maps_extended dto 7a61dfcd00
swagger: generate
Some checks failed
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is failing
Details
4353ec76bf
Quaternions added the backendenhancement labels 2025-08-06 01:30:27 +00:00
Quaternions added this to the Maps Migration project 2025-08-06 01:30:30 +00:00
Quaternions self-assigned this 2025-08-06 01:30:34 +00:00
Quaternions added 1 commit 2025-08-06 01:36:58 +00:00
update dev-service middleware vaildation to use Maps-Read
Some checks failed
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is failing
Details
9505106030
Quaternions requested review from itzaname 2025-08-06 01:38:14 +00:00
itzaname requested changes 2025-08-06 03:16:21 +00:00
Dismissed
itzaname left a comment
Owner
Copy Link

LGTM other than the doc change

LGTM other than the doc change
cmd/maps-service/service.go Outdated
@@ -10,0 +10,4 @@
// @title StrafesNET Maps API
// @version 1.0
// @description Obtain an api key at https://dev.strafes.net
// @description Requires Data:Read permission
itzaname commented 2025-08-06 01:49:58 +00:00
Owner
Copy Link

Maps:Read

Maps:Read
Quaternions marked this conversation as resolved
pkg/public_api/router.go Outdated
@@ -0,0 +90,4 @@
v1.GET("/map", mapsHandler.List)
v1.GET("/map/:id", mapsHandler.Get)
}
r.GET("/docs/*any", ginSwagger.WrapHandler(swaggerfiles.Handler))
itzaname commented 2025-08-06 03:16:18 +00:00
Owner
Copy Link

Do you plan to expose this as maps.strafes.net/docs or something else? My suggestion would be /public-api/docs and then have /public-api redirect to docs. The / route right now won't do anything.

Do you plan to expose this as maps.strafes.net/docs or something else? My suggestion would be /public-api/docs and then have /public-api redirect to docs. The / route right now won't do anything.
Quaternions commented 2025-08-06 03:54:52 +00:00
Author
Owner
Copy Link

I attempted to address this in this commit acc61124bc

I attempted to address this in this commit acc61124bca515d9eb438732584202f90d3cd6d7
itzaname marked this conversation as resolved
Quaternions added 2 commits 2025-08-06 03:50:13 +00:00
fix swagger docs 6d3d2c9f4b
serve docs at /public-api/docs
Some checks failed
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is failing
Details
f38b27fb40
Quaternions force-pushed public-api from f38b27fb40 to acc61124bc 2025-08-06 03:52:48 +00:00 Compare
itzaname approved these changes 2025-08-06 04:11:13 +00:00
itzaname commented 2025-08-06 04:38:48 +00:00
Owner
Copy Link

Maps:Read permission was added to staging dev-service and is default allowed for all users.

Maps:Read permission was added to staging dev-service and is default allowed for all users.
Quaternions changed title from WIP: Public API to Public API 2025-08-06 06:05:04 +00:00
Quaternions merged commit b83806cc34 into staging 2025-08-06 06:07:12 +00:00
Quaternions deleted branch public-api 2025-08-06 06:07:12 +00:00
Quaternions referenced this issue from a commit 2025-08-06 06:07:14 +00:00
Public API (#253)
Quaternions commented 2025-08-06 06:07:17 +00:00
Author
Owner
Copy Link

TODO: infra

TODO: infra
Quaternions referenced this issue from a commit 2025-08-06 06:08:31 +00:00
Public API (#253)
Quaternions moved this to Cleanup in Maps Migration on 2025-08-07 02:41:36 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
itzaname
Labels
Clear labels
backend
Submissions api related
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 frontend
Website related
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 validator
Map validation related
 wontfix
This won't be fixed
No Label backend enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project Maps Migration
Assignees
Clear assignees
aidan9382 CI dowoge ic3w0lf22 interpreterK itzaname Quaternions
No Assignees Quaternions
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: StrafesNET/maps-service#253
Delete Branch "public-api"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?