Clickable titles and show active mapfix #211
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: StrafesNET/maps-service#211
Reference in New Issue
Block a user
Delete Branch "issues-162-170"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #144
omg what have i done
i think it worked now i can delete this branch once merged :D
Rebase this branch onto staging and force-push to this branch
Pro tip: you can avoid this by creating a new branch based on staging for every pull request
e4cdb01951to18cf6774dff422c0465etoff69c95cd8@@ -90,0 +95,4 @@const targetAssetId = map.ID;async function fetchMapfixes() {try {const res = await fetch(`/api/mapfixes?Page=1&Limit=10&TargetAssetID=${targetAssetId}`);I don't think it's impossible for a map to ever have more than 10 fixes.
Backend currently only accepts one
StatusID(api/mapfixes?Page=1&Limit=10&TargetAssetID=78486780449372&StatusID=4), maybe this could be changed to allow multiple StatusIDs so the frontend wouldn't need to fetch multiple pages containing mapfixes that were already completed and having to filter them out.If not, I'll keep the current code as is.
Clickable titles, active mapfix, remember comment/audit event tabto WIP: Clickable titles, active mapfix, remember comment/audit event tabAs far as I can tell, this is ready to be merged unless the API change I suggested will be implemented.
WIP: Clickable titles, active mapfix, remember comment/audit event tabto Clickable titles, active mapfix, remember comment/audit event tabClickable titles, active mapfix, remember comment/audit event tabto Clickable titles show active mapfixClickable titles show active mapfixto Clickable titles and show active mapfixLGTM. In the future please attach screenshots of UI changes so it's easier to review.