StrafesNET/maps-service
4
Fork 4
Code Issues 21 Pull Requests Packages Projects Releases Wiki Activity

Taking care of some issues & QOL changes #209

Merged
itzaname merged 4 commits from issues-162-170 into staging 2025-06-28 07:45:00 +00:00
Conversation 4 Commits 4 Files Changed 21 +208 -33
ic3w0lf22 commented 2025-06-28 04:32:07 +00:00
Member
Copy Link

random note: I removed avatar from ReviewItemHeader since it used the submitter's avatar which does not match the creator's (there's also no way of getting the creator's avatar since anyone can set the creator to anything).

random note: I removed avatar from `ReviewItemHeader` since it used the submitter's avatar which does not match the creator's (there's also no way of getting the creator's avatar since anyone can set the creator to anything).
ic3w0lf22 added 2 commits 2025-06-28 04:32:08 +00:00
web: remove cursed ai code
All checks were successful
continuous-integration/drone/push Build is passing
Details
abb3cf3076
Added titles, some buttons, made submitter display usernames instead of userids, quick links
Some checks failed
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is failing
Details
f84f95fcc2 
Closes #162
Closes #170
ic3w0lf22 changed target branch from master to staging 2025-06-28 04:34:55 +00:00
itzaname commented 2025-06-28 05:07:10 +00:00
Owner
Copy Link

Build is failing, looks like you didn't add your new useTitle file before committing.

https://ci.itzana.me/StrafesNET/maps-service/1122

random note: I removed avatar from ReviewItemHeader since it used the submitter's avatar which does not match the creator's (there's also no way of getting the creator's avatar since anyone can set the creator to anything).

Keep the avatar, fill the submitter username instead since this PR add the ability to get that information. Showing the "creator" text next to the submitter avatar was a placeholder until something was added for querying usernames. On the review pages who is submitting the map/mapfix is more important.

Build is failing, looks like you didn't add your new useTitle file before committing. https://ci.itzana.me/StrafesNET/maps-service/1122 > random note: I removed avatar from ReviewItemHeader since it used the submitter's avatar which does not match the creator's (there's also no way of getting the creator's avatar since anyone can set the creator to anything). Keep the avatar, fill the submitter username instead since this PR add the ability to get that information. Showing the "creator" text next to the submitter avatar was a placeholder until something was added for querying usernames. On the review pages who is submitting the map/mapfix is more important.
ic3w0lf22 added 1 commit 2025-06-28 05:08:23 +00:00
Add missing files
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
879a80e4ff
ic3w0lf22 added 1 commit 2025-06-28 05:09:24 +00:00
Re-implement placeholder avatar
Some checks failed
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is failing
Details
7f939810cf
ic3w0lf22 added 1 commit 2025-06-28 05:30:08 +00:00
Submitter stuff
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
26314ff837
ic3w0lf22 commented 2025-06-28 05:32:15 +00:00
Author
Member
Copy Link

visual changes

image.png

visual changes ![image.png](/attachments/29f1bf03-9fc1-41dc-9503-11730a4af6f3)
image.png
13 KiB
👍 1
Quaternions approved these changes 2025-06-28 06:27:08 +00:00
Quaternions left a comment
Owner
Copy Link

LGTM (I'm a javascript noob)

LGTM (I'm a javascript noob)
Quaternions commented 2025-06-28 06:44:00 +00:00
Owner
Copy Link

Closes #162
Closes #170

Closes #162 Closes #170
itzaname merged commit 6f9cd952d4 into staging 2025-06-28 07:45:00 +00:00
itzaname deleted branch issues-162-170 2025-06-28 07:45:00 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Quaternions
Labels
Clear labels
backend
Submissions api related
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 frontend
Website related
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 validator
Map validation related
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aidan9382 CI dowoge ic3w0lf22 interpreterK itzaname Quaternions
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: StrafesNET/maps-service#209
Delete Branch "issues-162-170"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?