Fix Bypass Submit + Audit Checklist + Map Download Button #207

Merged

Quaternions merged 7 commits from staging into master 2025-06-24 06:41:57 +00:00

Conversation 0 Commits 7 Files Changed 44 +2553 -121

Quaternions commented 2025-06-24 06:18:38 +00:00

Owner

Copy Link

No description provided.

Quaternions added 11 commits 2025-06-24 06:18:38 +00:00

submissions-api: Add Releaser Endpoints (#194) ... 6a52166901

Also uses enums over ints for GameID.

Reviewed-on: #194
Co-authored-by: Quaternions <krakow20@gmail.com>
Co-committed-by: Quaternions <krakow20@gmail.com>

submissions-api: type all ids (#195) ... 463d14d2b5

Reviewed-on: #195
Co-authored-by: Quaternions <krakow20@gmail.com>
Co-committed-by: Quaternions <krakow20@gmail.com>

Compartmentalize Monolith (#196) ... 0834400c05

This isn't the full job, notably Operations are still sprinkled about, and having some code sharing between `service` and `service_internal` would be nice, but that is sketchy without the explicitness of Rust's traits.

Reviewed-on: #196
Co-authored-by: Quaternions <krakow20@gmail.com>
Co-committed-by: Quaternions <krakow20@gmail.com>

Change Error to Explicit Endpoint (#197) ... c4d97b6537

This changes the way that the internal api works.  The backend used to implicitly create an error for specifc endpoints, but now the validator explicitly creates the error itself.

Reviewed-on: #197
Co-authored-by: Quaternions <krakow20@gmail.com>
Co-committed-by: Quaternions <krakow20@gmail.com>

Replace bypass-submit with trigger-submit-unchecked (#199) ... 215c39000b

Bypassing the submit process means that the map revision is not updated.  Change the endpoint and include a flag to skip the map checks but update the revision.

Reviewed-on: #199
Co-authored-by: Quaternions <krakow20@gmail.com>
Co-committed-by: Quaternions <krakow20@gmail.com>

Validation: Make Assets Loadable on Maptest (#198) ... abd233ce65

Closes #43.

This is a very bare bones implementation, but gets us started on https://git.itzana.me/StrafesNET/maps-service/milestone/3

This will break production as written!  A proper implementation requires a separate api key since the maptest places are to be hosted on a different group.

Edit: It will actually not break, because it is using cookie access. The staging cookie has permission to edit StrafesNET Maptest asset permissions via StrafesNET_CI3, while prod also has access via StrafesNET_CI2.  Both staging and prod versions of the website will add maptest asset access to the same places on StrafesNET Maptest.
Reviewed-on: #198
Co-authored-by: Quaternions <krakow20@gmail.com>
Co-committed-by: Quaternions <krakow20@gmail.com>

Audit Event CheckList (#181) ... ed7109270f

Depends on #160, #196, #197.

Closes #147.

This introduces a new type of audit event: the CheckList.  This is a list of map checks that the validator performed.  The intention is to update the web interface to display ✅ check marks for every check passed and ❌ for every check failed, and also include the summary of why the check failed.  ~~The `Details` field would be the complete internal structure of the check in json, but I'm thinking it's unnecessary and should just be omitted.~~ The `Details` field has been removed.

```go
type Check struct {
	Name    string `json:"name"`
	Summary string `json:"summary"`
	Passed  bool   `json:"passed"`
}

type AuditEventDataCheckList struct {
	CheckList []Check `json:"check_list"`
}
```

This is created instead of the Error audit event when the validator requests changes, but the Error audit event can still be created for other purposes.

- [x] Make a proper error instead of hijacking a CheckList

Reviewed-on: #181
Reviewed-by: itzaname <itzaname@noreply@itzana.me>
Co-authored-by: Quaternions <krakow20@gmail.com>
Co-committed-by: Quaternions <krakow20@gmail.com>

validation: fixups 42cc783887

submissions-api: report script IDs not the whole thing 51f62f039b

Map Download Button (#201) ... 53cc4b9e9e

Closes #145.

All the backend should be implemented here, ~~I just don't know how to make a download button on the frontend.~~ I made a button, we'll see if it works.

- [x] ~~Add asset download api key to infra~~ this was never required

Reviewed-on: #201
Co-authored-by: Quaternions <krakow20@gmail.com>
Co-committed-by: Quaternions <krakow20@gmail.com>

Move Download Button Below Title (#206) ... 976adf2b66

Senior itzaname envisioned the button existing elsewhere.

Reviewed-on: #206
Co-authored-by: Quaternions <krakow20@gmail.com>
Co-committed-by: Quaternions <krakow20@gmail.com>

Quaternions added 1 commit 2025-06-24 06:36:24 +00:00

Revert "Validation: Make Assets Loadable on Maptest (#198)" ... 40b0af0063

This reverts commit abd233ce65.

Quaternions changed title from Fix Bypass Submit + Asset Permissions + Audit Checklist + Map Download Button to Fix Bypass Submit + Audit Checklist + Map Download Button 2025-06-24 06:36:44 +00:00

Quaternions merged commit dc446c545f into master 2025-06-24 06:41:57 +00:00

Quaternions referenced this issue from a commit 2025-06-24 06:41:59 +00:00

Fix Bypass Submit + Audit Checklist + Map Download Button (#207)

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

backend

Submissions api related

bug

Something is not working

duplicate

This issue or pull request already exists

enhancement

New feature

frontend

Website related

help wanted

Need some help

invalid

Something is wrong

question

More information is needed

validator

Map validation related

wontfix

This won't be fixed

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

aidan9382 CI dowoge ic3w0lf22 interpreterK itzaname Quaternions

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: StrafesNET/maps-service#207