StrafesNET/maps-service
4
Fork 4
Code Issues 22 Pull Requests 2 Packages Projects Releases Wiki Activity

First wave of QOL impovementss #190

Merged
itzaname merged 5 commits from feature/QOL-Fixes into staging 2025-06-10 02:18:56 +00:00
Conversation 2 Commits 5 Files Changed 9 +251 -229
itzaname commented 2025-06-10 02:09:33 +00:00
Owner
Copy Link

No screenshots but here is the list:

  • Updated all avatars/thumbnails to just 307 to the roblox cdn
  • Moved data loading for submissions and mapfixes into a common hook
  • Data will now auto refresh every 5 seconds if state Validating, Submitting, Uploading (ing Statuses) #102
  • A loading icon will also show when on a "ing" status
  • You don't have to be logged in to see the submissions/mapfixes
  • Added text if there are no comments
  • Hide comment box if not logged in

Maybe other things I wasn't paying attention.

No screenshots but here is the list: - Updated all avatars/thumbnails to just 307 to the roblox cdn - Moved data loading for submissions and mapfixes into a common hook - Data will now auto refresh every 5 seconds if state Validating, Submitting, Uploading (ing Statuses) https://git.itzana.me/StrafesNET/maps-service/issues/102 - A loading icon will also show when on a "ing" status - You don't have to be logged in to see the submissions/mapfixes - Added text if there are no comments - Hide comment box if not logged in Maybe other things I wasn't paying attention.
itzaname added the frontend label 2025-06-10 02:09:33 +00:00
itzaname self-assigned this 2025-06-10 02:09:33 +00:00
itzaname added 5 commits 2025-06-10 02:09:33 +00:00
Hide comment dialogue if not logged in and show no comments text if no comments b63cb99409
Switch to common data loading hook, with retries, and logged in/out user support. dd7b689f27
Add loading animation when processing 643a29e4db
Just redirect to roblox cdn for images
All checks were successful
continuous-integration/drone/push Build is passing
Details
2e0e36930e
Update review buttons to use central status pkg
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
97c41fd106
itzaname requested review from Quaternions 2025-06-10 02:09:33 +00:00
Quaternions approved these changes 2025-06-10 02:18:11 +00:00
Quaternions commented 2025-06-10 02:18:20 +00:00
Owner
Copy Link

LGTM

LGTM
itzaname merged commit 644c04c133 into staging 2025-06-10 02:18:56 +00:00
itzaname deleted branch feature/QOL-Fixes 2025-06-10 02:18:56 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Quaternions
Labels
Clear labels
backend
Submissions api related
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 frontend
Website related
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 validator
Map validation related
 wontfix
This won't be fixed
No Label frontend
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aidan9382 CI dowoge ic3w0lf22 interpreterK itzaname Quaternions
No Assignees itzaname
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: StrafesNET/maps-service#190
Delete Branch "feature/QOL-Fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?