Update Colours For Review Status (Take Two) #175

Closed

Quaternions wants to merge 5 commits from review-status-colours into staging

Quaternions commented

2025-06-07 23:49:23 +00:00

Owner

Supersedes #171.

This rebases onto staging branch, fixes up the status ids, and copies the colors over to mapfixes.

Supersedes #171. This rebases onto staging branch, fixes up the status ids, and copies the colors over to mapfixes.

Quaternions added 5 commits 2025-06-07 23:49:23 +00:00

Update web/src/app/submissions/[submissionId]/(styles)/page/reviewStatus.scss e3439d71f2

Update web/src/app/submissions/[submissionId]/(styles)/page/reviewStatus.scss 78c4cae02b

fix up ids af09834589

remove irrelevant items, add Submitting 2a768d4ff7

copy colors to mapfixes

continuous-integration/drone/push Build is passing

Details

continuous-integration/drone/pr Build is passing

Details

6f57d86997

Quaternions referenced this pull request

2025-06-07 23:50:12 +00:00

Update Colours For Review Status #171

itzaname requested changes 2025-06-08 00:04:56 +00:00

itzaname left a comment

Owner

Could be as simple as:

Failed: The map was rejected
Success: Final state(s)
Info (blue): Any transition state
Warning: Any state requiring interaction

Where each state falls to is up for debate though.

Would suggest standardizing on the material ui colors (success, warning, failed, primary, secondary) and then changing those in the theme if desired vs going around the ui framework. Don't think we need a bunch of different shades either. Could be as simple as: Failed: The map was rejected Success: Final state(s) Info (blue): Any transition state Warning: Any state requiring interaction Where each state falls to is up for debate though.

numberss commented

2025-06-08 00:17:52 +00:00

Member

this seems like a pretty simple solution. my only gripe would be where like changes requested or accepted, not validated would come under, since they could be considered to be in 2 states at the same time (failed but warning, success but warning).

itzaname commented

2025-06-08 00:52:54 +00:00

Owner

this seems like a pretty simple solution. my only gripe would be where like changes requested or accepted, not validated would come under, since they could be considered to be in 2 states at the same time (failed but warning, success but warning).

Changes Requested = Warn, Interaction Required (by Submitter)
Accepted, Not Validated = Warn, Interaction Required (by Quat)

> this seems like a pretty simple solution. my only gripe would be where like changes requested or accepted, not validated would come under, since they could be considered to be in 2 states at the same time (failed but warning, success but warning). Changes Requested = Warn, Interaction Required (by Submitter) Accepted, Not Validated = Warn, Interaction Required (by Quat)

itzaname commented

2025-06-08 01:53:43 +00:00

Owner

I'll be coming back through and re-doing the whole submission/map fix page so maybe this holds off until then? We can still standardize the colors/state names though.