StrafesNET/maps-service
4
Fork 4
Code Issues 23 Pull Requests 2 Packages Projects Releases Wiki Activity

Rework submission/mapfix/maps list views #173

Merged
itzaname merged 14 commits from feature/List-Refactors into staging 2025-06-08 03:41:37 +00:00
Conversation 11 Commits 14 Files Changed 11 +1332 -315
itzaname commented 2025-06-07 20:06:29 +00:00
Owner
Copy Link

Make boxes look moderately nicer and actually implement a grid. Bonus: pagination actually works now. Lazily vibe coded so making things re-usable wasn't in the budget.

image.png
Make boxes look moderately nicer and actually implement a grid. Bonus: pagination actually works now. Lazily vibe coded so making things re-usable wasn't in the budget. <img width="3005" alt="image.png" src="attachments/a01c4105-9047-4db7-a4a0-ec8149206e5d">
image.png
1.6 MiB
itzaname added the frontend label 2025-06-07 20:06:29 +00:00
itzaname self-assigned this 2025-06-07 20:06:29 +00:00
itzaname added 1 commit 2025-06-07 20:06:29 +00:00
Rework submission/mapfix list views
Some checks failed
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is failing
Details
dcbb2df319
itzaname requested review from Quaternions 2025-06-07 20:06:30 +00:00
itzaname added 1 commit 2025-06-07 20:08:10 +00:00
Fix missing creation date in submissions
Some checks failed
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is failing
Details
33036c3685
itzaname commented 2025-06-07 20:11:01 +00:00
Author
Owner
Copy Link

Also is responsive and supports people who are blind like @Quaternions

image.png
Also is responsive and supports people who are blind like @Quaternions <img width="2990" alt="image.png" src="attachments/2a8d2b76-6326-4c8b-917b-ec32419aaf1b">
image.png
1.7 MiB
itzaname added 1 commit 2025-06-07 20:13:39 +00:00
Fix wrong term in loading spinner...
Some checks failed
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is failing
Details
197e75c8c6
itzaname added 1 commit 2025-06-07 20:18:02 +00:00
Add missing import
Some checks failed
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is failing
Details
fb82dbd0ea
itzaname added 1 commit 2025-06-07 20:23:59 +00:00
Fix import so we're using the wonderfully deprecated Grid
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
8b184b1e8a
itzaname added 2 commits 2025-06-07 22:21:13 +00:00
Refactor navbar 3d5da108b4
Make submit button more obvious
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
9ce21399f7
itzaname commented 2025-06-07 22:22:25 +00:00
Author
Owner
Copy Link

Slight rework of the navbar as well

image.png
Slight rework of the navbar as well <img width="1176" alt="image.png" src="attachments/bf6af4f8-0c21-4548-bec3-9760e56633af">
image.png
301 KiB
dowoge commented 2025-06-07 22:24:05 +00:00
Member
Copy Link

looks alright I guess

looks alright I guess
itzaname commented 2025-06-07 22:26:31 +00:00
Author
Owner
Copy Link

looks alright I guess

Didn't ask

> looks alright I guess Didn't ask
itzaname added 2 commits 2025-06-07 23:34:05 +00:00
Use container for width, add typography. 1176d2f46f
Rework map list page
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
08bf4412c8
itzaname commented 2025-06-07 23:36:11 +00:00
Author
Owner
Copy Link

Added containers to control the width and added typography for the headings. Reworked the map list page to add a search and filtering. Just pull the entire map list into the client for this, no clue if it's going to work well with tons of entries.

image.png image.png
Added containers to control the width and added typography for the headings. Reworked the map list page to add a search and filtering. Just pull the entire map list into the client for this, no clue if it's going to work well with tons of entries. <img width="1430" alt="image.png" src="attachments/858a395e-4371-44f2-ad21-17786f6e3b7c"> <img width="1422" alt="image.png" src="attachments/41577b1a-d8c2-4fa3-acf0-075b1393fc35">
image.png
363 KiB
image.png
586 KiB
itzaname changed title from Rework submission/mapfix list views to Rework submission/mapfix/maps list views 2025-06-07 23:47:11 +00:00
itzaname added 1 commit 2025-06-08 00:54:07 +00:00
Update state color scheme
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
188fd94e22
itzaname added 1 commit 2025-06-08 01:49:43 +00:00
Hide submit button if not logged in
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
5d0818d1c6
itzaname added 1 commit 2025-06-08 01:51:57 +00:00
Submitted => Under Review
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
86fd6b173a
itzaname added 1 commit 2025-06-08 02:36:53 +00:00
Add landing page
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
354e93e787
itzaname commented 2025-06-08 02:37:40 +00:00
Author
Owner
Copy Link

Added the landing page so it's not blank when you load the site.

image.png
Added the landing page so it's not blank when you load the site. <img width="1727" alt="image.png" src="attachments/e1c23394-f2df-4145-9de8-72e55755fa1c">
image.png
703 KiB
👍 1
itzaname commented 2025-06-08 02:42:00 +00:00
Author
Owner
Copy Link

Gonna stop adding to this MR so it can be reviewed.

Gonna stop adding to this MR so it can be reviewed.
Quaternions requested changes 2025-06-08 03:25:04 +00:00
Dismissed
web/src/app/_components/mapCard.tsx
@@ -45,0 +42,4 @@
case 3:
color = 'warning';
icon = <CheckCircle fontSize="small"/>;
label = 'Under Review';
Quaternions commented 2025-06-08 03:16:33 +00:00
Owner
Copy Link

This says "Under Review" when the status is "Submitted". Is that on purpose?

This says "Under Review" when the status is "Submitted". Is that on purpose?
itzaname commented 2025-06-08 03:30:04 +00:00
Author
Owner
Copy Link

Took some liberty with the naming. "Under Review" more clearly communicates what is happening versus "Submitted". Would expect to make this change throughout.

Took some liberty with the naming. "Under Review" more clearly communicates what is happening versus "Submitted". Would expect to make this change throughout.
Quaternions marked this conversation as resolved
web/src/app/_components/mapCard.tsx Outdated
@@ -71,0 +194,4 @@
wordBreak: 'break-word',
}}
>
{props.gameID === 1 ? 'Bhop' : props.gameID === 2 ? 'Surf' : props.gameID === 3 ? 'Fly Trials' : props.gameID === 4 ? 'Deathrun' : 'Unknown'}
Quaternions commented 2025-06-08 03:17:38 +00:00
Owner
Copy Link

FlyTrials is GameID 5

FlyTrials is GameID 5
itzaname marked this conversation as resolved
web/src/app/maps/page.tsx Outdated
@@ -60,0 +120,4 @@
return "Bhop";
case 2:
return "Surf";
case 3:
Quaternions commented 2025-06-08 03:22:01 +00:00
Owner
Copy Link

FlyTrials = 5

FlyTrials = 5
itzaname marked this conversation as resolved
web/src/app/maps/page.tsx Outdated
@@ -60,0 +139,4 @@
bgcolor: "success.main",
color: "white",
};
case 3: // Fly Trials
Quaternions commented 2025-06-08 03:22:17 +00:00
Owner
Copy Link

FlyTrials = 5

FlyTrials = 5
itzaname marked this conversation as resolved
web/src/app/maps/page.tsx Outdated
@@ -60,0 +211,4 @@
<MenuItem value="0">All Maps</MenuItem>
<MenuItem value="1">Bhop</MenuItem>
<MenuItem value="2">Surf</MenuItem>
<MenuItem value="3">Fly Trials</MenuItem>
Quaternions commented 2025-06-08 03:22:43 +00:00
Owner
Copy Link

FlyTrials = 5

FlyTrials = 5
itzaname marked this conversation as resolved
Quaternions commented 2025-06-08 03:25:53 +00:00
Owner
Copy Link

Lots of code read, very little understood

Lots of code read, very little understood
itzaname added 1 commit 2025-06-08 03:36:30 +00:00
Fix fly trials game id
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
c3b47f5990
Quaternions approved these changes 2025-06-08 03:40:18 +00:00
Quaternions commented 2025-06-08 03:41:12 +00:00
Owner
Copy Link

LGTM

LGTM
itzaname merged commit 54bf3f55a0 into staging 2025-06-08 03:41:37 +00:00
itzaname deleted branch feature/List-Refactors 2025-06-08 03:41:37 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Quaternions
Labels
Clear labels
backend
Submissions api related
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 frontend
Website related
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 validator
Map validation related
 wontfix
This won't be fixed
No Label frontend
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aidan9382 CI dowoge ic3w0lf22 interpreterK itzaname Quaternions
No Assignees itzaname
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: StrafesNET/maps-service#173
Delete Branch "feature/List-Refactors"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?