StrafesNET/asset-tool
3
Fork 1
Code Issues Pull Requests Packages Projects Releases 4 Wiki Activity

fix decompiling history into git; enable output-folder for git related features #7

Merged
Quaternions merged 7 commits from aidan9382/asset-tool:master into staging 2024-10-01 20:08:01 +00:00
Conversation 1 Commits 7 Files Changed 1 +8 -8
aidan9382 commented 2024-10-01 19:37:29 +00:00
Member
Copy Link

Why does this work and the version with the directory doesn't? yeah idk. But hey, this one successfully stages the files, so ill take it

Probably something about The pathspecs are a list of file names or shell glob patterns that will matched against files in the repository’s working directory (taken from git2 add_all docs), so its probably double-stacking working directories or something

Why does this work and the version with the directory doesn't? yeah idk. But hey, this one successfully stages the files, so ill take it Probably something about `The pathspecs are a list of file names or shell glob patterns that will matched against files in the repository’s working directory` (taken from git2 add_all docs), so its probably double-stacking working directories or something
aidan9382 added 1 commit 2024-10-01 19:37:29 +00:00 
Why does this work and the version with the directory doesn't? yeah idk. But hey, this one successfully stages the files, so ill take it
aidan9382 changed title from fix decompiling history into git to WIP: fix decompiling history into git 2024-10-01 19:39:14 +00:00
aidan9382 added 1 commit 2024-10-01 19:44:51 +00:00 
Repository-based logic seems to automatically be made relative to the top-level path the repo was initialised with, so we can actually support an output folder with no issues here
aidan9382 force-pushed master from ef76dd5922 to 4cb8fd1c7d 2024-10-01 19:45:06 +00:00 Compare
aidan9382 changed title from WIP: fix decompiling history into git to fix decompiling history into git; enable output-folder for git related features 2024-10-01 19:45:20 +00:00
aidan9382 commented 2024-10-01 19:46:39 +00:00
Author
Member
Copy Link

Tested using a sub-folder of the folder I ran the asset-tool from and everything worked fine (the repository was made and changes were committed without much complaining beyond an initial "repo head error", which is probably not good but I'm not overly bothered about fixing it right now and happened before this change anyways)

Tested using a sub-folder of the folder I ran the asset-tool from and everything worked fine (the repository was made and changes were committed without much complaining beyond an initial "repo head error", which is probably not good but I'm not overly bothered about fixing it right now and happened before this change anyways)
Quaternions changed target branch from master to staging 2024-10-01 20:05:31 +00:00
Quaternions merged commit c6a8246513 into staging 2024-10-01 20:08:01 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: StrafesNET/asset-tool#7
No description provided.
Delete Branch "aidan9382/asset-tool:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?