support output-folder option for git-related features

Repository-based logic seems to automatically be made relative to the top-level path the repo was initialised with, so we can actually support an output folder with no issues here

.drone.yml

@@ -0,0 +1,24 @@
+---
+kind: pipeline
+type: docker
+
+platform:
+  os: linux
+  arch: amd64
+
+steps:
+  - name: image
+    image: plugins/docker
+    settings:
+      registry: git.itzana.me
+      repo: git.itzana.me/strafesnet/asset-tool
+      tags:
+        - latest
+      username:
+        from_secret: GIT_USER
+      password:
+        from_secret: GIT_PASS
+      dockerfile: Containerfile
+    when:
+      branch:
+        - master

Cargo.toml

@@ -1,7 +1,7 @@
 workspace = { members = ["rbx_asset", "rox_compiler"] }
 [package]
 name = "asset-tool"
-version = "0.3.4"
+version = "0.4.6"
 edition = "2021"
 
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

Containerfile

@@ -1,6 +1,6 @@
 # Using the `rust-musl-builder` as base image, instead of 
 # the official Rust toolchain
-FROM clux/muslrust:stable AS chef
+FROM docker.io/clux/muslrust:stable AS chef
 USER root
 RUN cargo install cargo-chef
 WORKDIR /app
@@ -16,8 +16,8 @@ RUN cargo chef cook --release --target x86_64-unknown-linux-musl --recipe-path r
 COPY . .
 RUN cargo build --release --target x86_64-unknown-linux-musl --bin asset-tool
 
-FROM alpine AS runtime
+FROM docker.io/alpine:latest AS runtime
 RUN addgroup -S myuser && adduser -S myuser -G myuser
 COPY --from=builder /app/target/x86_64-unknown-linux-musl/release/asset-tool /usr/local/bin/
 USER myuser
-CMD ["/usr/local/bin/asset-tool"]
+ENTRYPOINT ["/usr/local/bin/asset-tool"]

README.md

@@ -1,3 +1,21 @@
 # asset-tool
 
+[![Build Status](https://ci.itzana.me/api/badges/StrafesNET/asset-tool/status.svg?ref=refs/heads/master)](https://ci.itzana.me/StrafesNET/asset-tool)
+
 For uploading and downloading roblox assets.
+
+See [releases](https://git.itzana.me/StrafesNET/asset-tool/releases) for downloads.
+
+To get started, you will need an api key and/or cookie depending on which command you use.  Api keys can be created from the open cloud section on the creator hub, cookies must be extracted from a browser session.  Do not share your cookie file with anyone or use it with tools that you do not trust, as it gives unrestricted permissions to do any account actions on your behalf.  The api keys are significantly more safe because you can choose exactly what permissions the given key has, and which ip addresses can use it.
+
+The help text lists available commands:
+
+`asset-tool --help`
+
+For help with a specific command:
+
+`asset-tool download --help`
+
+Example incantation to download a list of models:
+
+`asset-tool download --cookie-file Documents\mycookie.txt 255299419 1213190363`

rbx_asset/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "rbx_asset"
-version = "0.2.0"
+version = "0.2.2"
 edition = "2021"
 publish = ["strafesnet"]
 

rbx_asset/src/cloud.rs

@@ -14,9 +14,33 @@ pub struct CreateAssetRequest{
 	pub displayName:String,
 }
 #[derive(Debug)]
+pub enum AssetOperationError{
+	Operation(OperationError),
+	Serialize(serde_json::Error),
+}
+impl std::fmt::Display for AssetOperationError{
+	fn fmt(&self,f:&mut std::fmt::Formatter<'_>)->std::fmt::Result{
+		write!(f,"{self:?}")
+	}
+}
+impl std::error::Error for AssetOperationError{}
+#[derive(Debug)]
+pub struct AssetOperation{
+	operation:RobloxOperation,
+}
+impl AssetOperation{
+	pub async fn try_get_asset(&self,context:&CloudContext)->Result<AssetResponse,AssetOperationError>{
+		serde_json::from_value(
+			self.operation
+				.try_get_reponse(context).await
+				.map_err(AssetOperationError::Operation)?
+		).map_err(AssetOperationError::Serialize)
+	}
+}
+#[derive(Debug)]
 pub enum CreateError{
-	ParseError(url::ParseError),
+	Parse(url::ParseError),
-	SerializeError(serde_json::Error),
+	Serialize(serde_json::Error),
 	Reqwest(reqwest::Error),
 }
 impl std::fmt::Display for CreateError{
@@ -35,24 +59,29 @@ pub struct UpdateAssetRequest{
 }
 
 //woo nested roblox stuff
-#[derive(Debug,serde::Deserialize,serde::Serialize)]
+#[derive(Clone,Debug,serde::Deserialize,serde::Serialize)]
 #[allow(nonstandard_style,dead_code)]
-pub struct Creator{
+pub enum Creator{
-	pub userId:u64,
+	userId(String),//u64 string
-	pub groupId:u64,
+	groupId(String),//u64 string
 }
 #[derive(Debug,serde::Deserialize,serde::Serialize)]
 #[allow(nonstandard_style,dead_code)]
 pub struct CreationContext{
 	pub creator:Creator,
-	pub expectedPrice:u64,
+	pub expectedPrice:Option<u64>,
 }
 #[derive(Debug,serde::Deserialize,serde::Serialize)]
 #[allow(nonstandard_style,dead_code)]
-pub enum ModerationResult{
+pub enum ModerationState{
-	MODERATION_STATE_REVIEWING,
+	Reviewing,
-	MODERATION_STATE_REJECTED,
+	Rejected,
-	MODERATION_STATE_APPROVED,
+	Approved,
+}
+#[derive(Debug,serde::Deserialize,serde::Serialize)]
+#[allow(nonstandard_style,dead_code)]
+pub struct ModerationResult{
+	pub moderationState:ModerationState,
 }
 #[derive(Debug,serde::Deserialize,serde::Serialize)]
 #[allow(nonstandard_style,dead_code)]
@@ -60,20 +89,6 @@ pub struct Preview{
 	pub asset:String,
 	pub altText:String,
 }
-#[derive(Debug,serde::Deserialize,serde::Serialize)]
-#[allow(nonstandard_style,dead_code)]
-pub struct AssetResponse{
-	pub assetId:u64,
-	pub creationContext:CreationContext,
-	pub description:String,
-	pub displayName:String,
-	pub path:String,
-	pub revisionId:u64,
-	pub revisionCreateTime:chrono::DateTime<chrono::Utc>,
-	pub moderationResult:ModerationResult,
-	pub icon:String,
-	pub previews:Vec<Preview>,
-}
 #[allow(nonstandard_style,dead_code)]
 pub struct UpdatePlaceRequest{
 	pub universeId:u64,
@@ -91,12 +106,59 @@ pub enum UpdateError{
 	Reqwest(reqwest::Error),
 }
 impl std::fmt::Display for UpdateError{
-	fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+	fn fmt(&self,f:&mut std::fmt::Formatter<'_>)->std::fmt::Result{
 		write!(f,"{self:?}")
 	}
 }
 impl std::error::Error for UpdateError{}
 
+struct GetAssetOperationRequest{
+	operation_id:String,
+}
+pub struct GetAssetInfoRequest{
+	pub asset_id:u64,
+}
+/*
+{
+    "assetId": "5692158972",
+    "assetType": "Model",
+    "creationContext":{
+        "creator":
+        {
+            "groupId": "6980477"
+        }
+    },
+    "description": "DisplayName: Ares\nCreator: titanicguy54",
+    "displayName": "bhop_ares.rbxmx",
+    "path": "assets/5692158972",
+    "revisionCreateTime": "2020-09-14T16:08:05.063Z",
+    "revisionId": "1",
+    "moderationResult":{
+        "moderationState": "Approved"
+    },
+    "state": "Active"
+}
+*/
+#[derive(Debug,serde::Deserialize,serde::Serialize)]
+#[allow(nonstandard_style,dead_code)]
+pub struct AssetResponse{
+	pub assetId:String,//u64 wrapped in quotes wohoo!!
+	pub assetType:AssetType,
+	pub creationContext:CreationContext,
+	pub description:String,
+	pub displayName:String,
+	pub path:String,
+	pub revisionCreateTime:chrono::DateTime<chrono::Utc>,
+	pub revisionId:String,//u64
+	pub moderationResult:ModerationResult,
+	pub icon:Option<String>,
+	pub previews:Option<Vec<Preview>>,
+}
+#[allow(nonstandard_style,dead_code)]
+pub struct GetAssetVersionRequest{
+	pub asset_id:u64,
+	pub version:u64,
+}
 #[allow(nonstandard_style,dead_code)]
 pub struct GetAssetRequest{
 	pub asset_id:u64,
@@ -109,7 +171,7 @@ pub enum GetError{
 	IO(std::io::Error)
 }
 impl std::fmt::Display for GetError{
-	fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+	fn fmt(&self,f:&mut std::fmt::Formatter<'_>)->std::fmt::Result{
 		write!(f,"{self:?}")
 	}
 }
@@ -119,7 +181,7 @@ pub struct AssetVersionsRequest{
 	pub asset_id:u64,
 	pub cursor:Option<String>,
 }
-#[derive(serde::Deserialize,serde::Serialize)]
+#[derive(Debug,serde::Deserialize,serde::Serialize)]
 #[allow(nonstandard_style,dead_code)]
 pub struct AssetVersion{
 	pub Id:u64,
@@ -131,7 +193,7 @@ pub struct AssetVersion{
 	pub created:chrono::DateTime<chrono::Utc>,
 	pub isPublished:bool,
 }
-#[derive(serde::Deserialize)]
+#[derive(Debug,serde::Deserialize)]
 #[allow(nonstandard_style,dead_code)]
 pub struct AssetVersionsResponse{
 	pub previousPageCursor:Option<String>,
@@ -144,7 +206,7 @@ pub enum AssetVersionsError{
 	Reqwest(reqwest::Error),
 }
 impl std::fmt::Display for AssetVersionsError{
-	fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+	fn fmt(&self,f:&mut std::fmt::Formatter<'_>)->std::fmt::Result{
 		write!(f,"{self:?}")
 	}
 }
@@ -154,13 +216,13 @@ pub struct InventoryPageRequest{
 	pub group:u64,
 	pub cursor:Option<String>,
 }
-#[derive(serde::Deserialize,serde::Serialize)]
+#[derive(Debug,serde::Deserialize,serde::Serialize)]
 #[allow(nonstandard_style,dead_code)]
 pub struct InventoryItem{
 	pub id:u64,
 	pub name:String,
 }
-#[derive(serde::Deserialize,serde::Serialize)]
+#[derive(Debug,serde::Deserialize,serde::Serialize)]
 #[allow(nonstandard_style,dead_code)]
 pub struct InventoryPageResponse{
 	pub totalResults:u64,//up to 50
@@ -179,12 +241,54 @@ pub enum InventoryPageError{
 	Reqwest(reqwest::Error),
 }
 impl std::fmt::Display for InventoryPageError{
-	fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+	fn fmt(&self,f:&mut std::fmt::Formatter<'_>)->std::fmt::Result{
 		write!(f,"{self:?}")
 	}
 }
 impl std::error::Error for InventoryPageError{}
 
+#[derive(Debug)]
+pub enum OperationError{
+	Get(GetError),
+	NoOperationId,
+	NotDone,
+}
+impl std::fmt::Display for OperationError{
+	fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+		write!(f,"{self:?}")
+	}
+}
+impl std::error::Error for OperationError{}
+#[derive(Debug,serde::Deserialize,serde::Serialize)]
+#[allow(nonstandard_style,dead_code)]
+struct RobloxOperation{
+	pub path:Option<String>,
+	pub metadata:Option<String>,
+	pub done:Option<bool>,
+	pub error:Option<String>,
+	pub response:Option<serde_json::Value>,
+	pub operationId:Option<String>,
+}
+impl RobloxOperation{
+	pub fn operation_id(&self)->Option<&str>{
+		match self.operationId.as_deref(){
+			//try getting it from undocumented operationId first
+			Some(operation_id)=>Some(operation_id),
+			//skip the first 11 characters
+			//operations/[uuid]
+			None=>self.path.as_deref()?.get(11..),
+		}
+	}
+	pub async fn try_get_reponse(&self,context:&CloudContext)->Result<serde_json::Value,OperationError>{
+		context.get_asset_operation(GetAssetOperationRequest{
+			operation_id:self.operation_id()
+				.ok_or(OperationError::NoOperationId)?
+				.to_owned(),
+		}).await.map_err(OperationError::Get)?
+		.response.ok_or(OperationError::NotDone)
+	}
+}
+
 //idk how to do this better
 enum ReaderType<R:std::io::Read>{
 	GZip(flate2::read::GzDecoder<std::io::BufReader<R>>),
@@ -205,15 +309,26 @@ fn read_readable(mut readable:impl std::io::Read)->std::io::Result<Vec<u8>>{
 }
 
 #[derive(Clone)]
-pub struct RobloxContext{
+pub struct ApiKey(String);
+impl ApiKey{
+	pub fn new(api_key:String)->Self{
+		Self(api_key)
+	}
+	pub fn get(self)->String{
+		self.0
+	}
+}
+
+#[derive(Clone)]
+pub struct CloudContext{
 	pub api_key:String,
 	pub client:reqwest::Client,
 }
 
-impl RobloxContext{
+impl CloudContext{
-	pub fn new(api_key:String)->Self{
+	pub fn new(api_key:ApiKey)->Self{
 		Self{
-			api_key,
+			api_key:api_key.get(),
 			client:reqwest::Client::new(),
 		}
 	}
@@ -240,20 +355,29 @@ impl RobloxContext{
 		.multipart(form)
 		.send().await
 	}
-	pub async fn create_asset(&self,config:CreateAssetRequest,body:impl Into<std::borrow::Cow<'static,[u8]>>)->Result<AssetResponse,CreateError>{
+	pub async fn create_asset(&self,config:CreateAssetRequest,body:impl Into<std::borrow::Cow<'static,[u8]>>)->Result<AssetOperation,CreateError>{
-		let url=reqwest::Url::parse("https://apis.roblox.com/assets/v1/assets").map_err(CreateError::ParseError)?;
+		let url=reqwest::Url::parse("https://apis.roblox.com/assets/v1/assets").map_err(CreateError::Parse)?;
 
-		let request_config=serde_json::to_string(&config).map_err(CreateError::SerializeError)?;
+		let request_config=serde_json::to_string(&config).map_err(CreateError::Serialize)?;
+
+		let part=reqwest::multipart::Part::bytes(body)
+		//you must have a file name or roblox will 400!!!!!!!!!
+		.file_name("image");
 
 		let form=reqwest::multipart::Form::new()
 		.text("request",request_config)
-		.part("fileContent",reqwest::multipart::Part::bytes(body));
+		.part("fileContent",part);
 
-		let resp=self.post_form(url,form).await.map_err(CreateError::Reqwest)?;
+		let operation=self.post_form(url,form).await
+		.map_err(CreateError::Reqwest)?
+		.error_for_status().map_err(CreateError::Reqwest)?
+		.json::<RobloxOperation>().await.map_err(CreateError::Reqwest)?;
 
-		Ok(resp.json::<AssetResponse>().await.map_err(CreateError::Reqwest)?)
+		Ok(AssetOperation{
+			operation,
+		})
 	}
-	pub async fn update_asset(&self,config:UpdateAssetRequest,body:impl Into<std::borrow::Cow<'static,[u8]>>)->Result<AssetResponse,UpdateError>{
+	pub async fn update_asset(&self,config:UpdateAssetRequest,body:impl Into<std::borrow::Cow<'static,[u8]>>)->Result<AssetOperation,UpdateError>{
 		let raw_url=format!("https://apis.roblox.com/assets/v1/assets/{}",config.assetId);
 		let url=reqwest::Url::parse(raw_url.as_str()).map_err(UpdateError::ParseError)?;
 
@@ -263,23 +387,39 @@ impl RobloxContext{
 		.text("request",request_config)
 		.part("fileContent",reqwest::multipart::Part::bytes(body));
 
-		let resp=self.patch_form(url,form).await.map_err(UpdateError::Reqwest)?;
+		let operation=self.patch_form(url,form).await
+		.map_err(UpdateError::Reqwest)?
+		//roblox api documentation is very poor, just give the status code and drop the json
+		.error_for_status().map_err(UpdateError::Reqwest)?
+		.json::<RobloxOperation>().await.map_err(UpdateError::Reqwest)?;
 
-		Ok(resp.json::<AssetResponse>().await.map_err(UpdateError::Reqwest)?)
+		Ok(AssetOperation{
+			operation,
+		})
 	}
-	pub async fn get_asset(&self,config:GetAssetRequest)->Result<Vec<u8>,GetError>{
+	async fn get_asset_operation(&self,config:GetAssetOperationRequest)->Result<RobloxOperation,GetError>{
-		let mut url=reqwest::Url::parse("https://assetdelivery.roblox.com/v1/asset/").map_err(GetError::ParseError)?;
+		let raw_url=format!("https://apis.roblox.com/assets/v1/operations/{}",config.operation_id);
-		//url borrow scope
+		let url=reqwest::Url::parse(raw_url.as_str()).map_err(GetError::ParseError)?;
-		{
-			let mut query=url.query_pairs_mut();//borrow here
-			query.append_pair("ID",config.asset_id.to_string().as_str());
-			if let Some(version)=config.version{
-				query.append_pair("version",version.to_string().as_str());
-			}
-		}
-		let resp=self.get(url).await.map_err(GetError::Reqwest)?;
 
-		let body=resp.bytes().await.map_err(GetError::Reqwest)?;
+		self.get(url).await.map_err(GetError::Reqwest)?
+		.error_for_status().map_err(GetError::Reqwest)?
+		.json::<RobloxOperation>().await.map_err(GetError::Reqwest)
+	}
+	pub async fn get_asset_info(&self,config:GetAssetInfoRequest)->Result<AssetResponse,GetError>{
+		let raw_url=format!("https://apis.roblox.com/assets/v1/assets/{}",config.asset_id);
+		let url=reqwest::Url::parse(raw_url.as_str()).map_err(GetError::ParseError)?;
+
+		self.get(url).await.map_err(GetError::Reqwest)?
+		.error_for_status().map_err(GetError::Reqwest)?
+		.json::<AssetResponse>().await.map_err(GetError::Reqwest)
+	}
+	pub async fn get_asset_version(&self,config:GetAssetVersionRequest)->Result<Vec<u8>,GetError>{
+		let raw_url=format!("https://apis.roblox.com/assets/v1/assets/{}/versions/{}",config.asset_id,config.version);
+		let url=reqwest::Url::parse(raw_url.as_str()).map_err(GetError::ParseError)?;
+
+		let body=self.get(url).await.map_err(GetError::Reqwest)?
+		.error_for_status().map_err(GetError::Reqwest)?
+		.bytes().await.map_err(GetError::Reqwest)?;
 
 		match maybe_gzip_decode(&mut std::io::Cursor::new(body)){
 			Ok(ReaderType::GZip(readable))=>read_readable(readable),
@@ -287,12 +427,23 @@ impl RobloxContext{
 			Err(e)=>Err(e),
 		}.map_err(GetError::IO)
 	}
+	pub async fn get_asset(&self,config:GetAssetRequest)->Result<Vec<u8>,GetError>{
+		let version=match config.version{
+			Some(version)=>version,
+			None=>self.get_asset_info(GetAssetInfoRequest{asset_id:config.asset_id}).await?.revisionId.parse().unwrap(),
+		};
+		self.get_asset_version(GetAssetVersionRequest{
+			asset_id:config.asset_id,
+			version,
+		}).await
+	}
 	pub async fn get_asset_versions(&self,config:AssetVersionsRequest)->Result<AssetVersionsResponse,AssetVersionsError>{
 		let raw_url=format!("https://apis.roblox.com/assets/v1/assets/{}/versions",config.asset_id);
 		let url=reqwest::Url::parse(raw_url.as_str()).map_err(AssetVersionsError::ParseError)?;
 
-		Ok(self.get(url).await.map_err(AssetVersionsError::Reqwest)?
+		self.get(url).await.map_err(AssetVersionsError::Reqwest)?
-		.json::<AssetVersionsResponse>().await.map_err(AssetVersionsError::Reqwest)?)
+		.error_for_status().map_err(AssetVersionsError::Reqwest)?
+		.json::<AssetVersionsResponse>().await.map_err(AssetVersionsError::Reqwest)
 	}
 	pub async fn inventory_page(&self,config:InventoryPageRequest)->Result<InventoryPageResponse,InventoryPageError>{
 		let mut url=reqwest::Url::parse(format!("https://apis.roblox.com/toolbox-service/v1/creations/group/{}/10?limit=50",config.group).as_str()).map_err(InventoryPageError::ParseError)?;
@@ -304,15 +455,21 @@ impl RobloxContext{
 			}
 		}
 
-		Ok(self.get(url).await.map_err(InventoryPageError::Reqwest)?
+		self.get(url).await.map_err(InventoryPageError::Reqwest)?
-		.json::<InventoryPageResponse>().await.map_err(InventoryPageError::Reqwest)?)
+		.error_for_status().map_err(InventoryPageError::Reqwest)?
+		.json::<InventoryPageResponse>().await.map_err(InventoryPageError::Reqwest)
 	}
 	pub async fn update_place(&self,config:UpdatePlaceRequest,body:impl Into<reqwest::Body>+Clone)->Result<UpdatePlaceResponse,UpdateError>{
 		let raw_url=format!("https://apis.roblox.com/universes/v1/{}/places/{}/versions",config.universeId,config.placeId);
-		let url=reqwest::Url::parse(raw_url.as_str()).map_err(UpdateError::ParseError)?;
+		let mut url=reqwest::Url::parse(raw_url.as_str()).map_err(UpdateError::ParseError)?;
+		//url borrow scope
+		{
+			let mut query=url.query_pairs_mut();//borrow here
+			query.append_pair("versionType","Published");
+		}
 
-		let resp=self.post(url,body).await.map_err(UpdateError::Reqwest)?;
+		self.post(url,body).await.map_err(UpdateError::Reqwest)?
-
+		.error_for_status().map_err(UpdateError::Reqwest)?
-		Ok(resp.json::<UpdatePlaceResponse>().await.map_err(UpdateError::Reqwest)?)
+		.json::<UpdatePlaceResponse>().await.map_err(UpdateError::Reqwest)
 	}
 }

rbx_asset/src/cookie.rs

@@ -0,0 +1,322 @@
+#[derive(Debug)]
+pub enum PostError{
+	Reqwest(reqwest::Error),
+	CSRF,
+}
+impl std::fmt::Display for PostError{
+	fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+		write!(f,"{self:?}")
+	}
+}
+impl std::error::Error for PostError{}
+
+#[derive(Debug,serde::Deserialize,serde::Serialize)]
+#[allow(nonstandard_style,dead_code)]
+pub struct CreateRequest{
+	pub name:String,
+	pub description:String,
+	pub ispublic:bool,
+	pub allowComments:bool,
+	pub groupId:Option<u64>,
+}
+#[derive(Debug)]
+pub enum CreateError{
+	ParseError(url::ParseError),
+	PostError(PostError),
+	Reqwest(reqwest::Error),
+}
+impl std::fmt::Display for CreateError{
+	fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+		write!(f,"{self:?}")
+	}
+}
+impl std::error::Error for CreateError{}
+
+#[allow(nonstandard_style,dead_code)]
+pub struct UploadRequest{
+	pub assetid:u64,
+	pub name:Option<String>,
+	pub description:Option<String>,
+	pub ispublic:Option<bool>,
+	pub allowComments:Option<bool>,
+	pub groupId:Option<u64>,
+}
+#[derive(Debug)]
+pub enum UploadError{
+	ParseError(url::ParseError),
+	PostError(PostError),
+	Reqwest(reqwest::Error),
+	AssetIdIsZero,
+}
+impl std::fmt::Display for UploadError{
+	fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+		write!(f,"{self:?}")
+	}
+}
+impl std::error::Error for UploadError{}
+#[derive(Debug,serde::Deserialize,serde::Serialize)]
+#[allow(nonstandard_style,dead_code)]
+pub struct UploadResponse{
+	pub AssetId:u64,
+	pub AssetVersionId:u64,
+}
+
+#[allow(nonstandard_style,dead_code)]
+pub struct GetAssetRequest{
+	pub asset_id:u64,
+	pub version:Option<u64>,
+}
+#[derive(Debug)]
+pub enum GetError{
+	ParseError(url::ParseError),
+	Reqwest(reqwest::Error),
+	IO(std::io::Error)
+}
+impl std::fmt::Display for GetError{
+	fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+		write!(f,"{self:?}")
+	}
+}
+impl std::error::Error for GetError{}
+
+pub struct AssetVersionsPageRequest{
+	pub asset_id:u64,
+	pub cursor:Option<String>,
+}
+#[derive(serde::Deserialize,serde::Serialize)]
+#[allow(nonstandard_style,dead_code)]
+pub struct AssetVersion{
+	pub Id:u64,
+	pub assetId:u64,
+	pub assetVersionNumber:u64,
+	pub creatorType:String,
+	pub creatorTargetId:u64,
+	pub creatingUniverseId:Option<u64>,
+	pub created:chrono::DateTime<chrono::Utc>,
+	pub isPublished:bool,
+}
+#[derive(serde::Deserialize)]
+#[allow(nonstandard_style,dead_code)]
+pub struct AssetVersionsPageResponse{
+	pub previousPageCursor:Option<String>,
+	pub nextPageCursor:Option<String>,
+	pub data:Vec<AssetVersion>,
+}
+#[derive(Debug)]
+pub enum AssetVersionsPageError{
+	ParseError(url::ParseError),
+	Reqwest(reqwest::Error),
+}
+impl std::fmt::Display for AssetVersionsPageError{
+	fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+		write!(f,"{self:?}")
+	}
+}
+impl std::error::Error for AssetVersionsPageError{}
+
+pub struct InventoryPageRequest{
+	pub group:u64,
+	pub cursor:Option<String>,
+}
+#[derive(serde::Deserialize,serde::Serialize)]
+#[allow(nonstandard_style,dead_code)]
+pub struct InventoryItem{
+	pub id:u64,
+	pub name:String,
+}
+#[derive(serde::Deserialize,serde::Serialize)]
+#[allow(nonstandard_style,dead_code)]
+pub struct InventoryPageResponse{
+	pub totalResults:u64,//up to 50
+	pub filteredKeyword:Option<String>,//""
+	pub searchDebugInfo:Option<String>,//null
+	pub spellCheckerResult:Option<String>,//null
+	pub queryFacets:Option<String>,//null
+	pub imageSearchStatus:Option<String>,//null
+	pub previousPageCursor:Option<String>,
+	pub nextPageCursor:Option<String>,
+	pub data:Vec<InventoryItem>,
+}
+#[derive(Debug)]
+pub enum InventoryPageError{
+	ParseError(url::ParseError),
+	Reqwest(reqwest::Error),
+}
+impl std::fmt::Display for InventoryPageError{
+	fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+		write!(f,"{self:?}")
+	}
+}
+impl std::error::Error for InventoryPageError{}
+
+//idk how to do this better
+enum ReaderType<R:std::io::Read>{
+	GZip(flate2::read::GzDecoder<std::io::BufReader<R>>),
+	Raw(std::io::BufReader<R>),
+}
+fn maybe_gzip_decode<R:std::io::Read>(input:R)->std::io::Result<ReaderType<R>>{
+	let mut buf=std::io::BufReader::new(input);
+	let peek=std::io::BufRead::fill_buf(&mut buf)?;
+	match &peek[0..2]{
+		b"\x1f\x8b"=>Ok(ReaderType::GZip(flate2::read::GzDecoder::new(buf))),
+		_=>Ok(ReaderType::Raw(buf)),
+	}
+}
+fn read_readable(mut readable:impl std::io::Read)->std::io::Result<Vec<u8>>{
+	let mut contents=Vec::new();
+	readable.read_to_end(&mut contents)?;
+	Ok(contents)
+}
+
+#[derive(Clone)]
+pub struct Cookie(String);
+impl Cookie{
+	pub fn new(cookie:String)->Self{
+		Self(cookie)
+	}
+	pub fn get(self)->String{
+		self.0
+	}
+}
+#[derive(Clone)]
+pub struct CookieContext{
+	pub cookie:String,
+	pub client:reqwest::Client,
+}
+
+impl CookieContext{
+	pub fn new(cookie:Cookie)->Self{
+		Self{
+			cookie:cookie.get(),
+			client:reqwest::Client::new(),
+		}
+	}
+	async fn get(&self,url:impl reqwest::IntoUrl)->Result<reqwest::Response,reqwest::Error>{
+		self.client.get(url)
+		.header("Cookie",self.cookie.as_str())
+		.send().await
+	}
+	async fn post(&self,url:url::Url,body:impl Into<reqwest::Body>+Clone)->Result<reqwest::Response,PostError>{
+		let mut resp=self.client.post(url.clone())
+		.header("Cookie",self.cookie.as_str())
+		.body(body.clone())
+		.send().await.map_err(PostError::Reqwest)?;
+
+		//This is called a CSRF challenge apparently
+		if resp.status()==reqwest::StatusCode::FORBIDDEN{
+			if let Some(csrf_token)=resp.headers().get("X-CSRF-Token"){
+				resp=self.client.post(url)
+				.header("X-CSRF-Token",csrf_token)
+				.header("Cookie",self.cookie.as_str())
+				.body(body)
+				.send().await.map_err(PostError::Reqwest)?;
+			}else{
+				Err(PostError::CSRF)?;
+			}
+		}
+
+		Ok(resp)
+	}
+	pub async fn create(&self,config:CreateRequest,body:impl Into<reqwest::Body>+Clone)->Result<UploadResponse,CreateError>{
+		let mut url=reqwest::Url::parse("https://data.roblox.com/Data/Upload.ashx?json=1&type=Model&genreTypeId=1").map_err(CreateError::ParseError)?;
+		//url borrow scope
+		{
+			let mut query=url.query_pairs_mut();//borrow here
+			//archaic roblox api uses 0 for new asset
+			query.append_pair("assetid","0");
+			query.append_pair("name",config.name.as_str());
+			query.append_pair("description",config.description.as_str());
+			query.append_pair("ispublic",if config.ispublic{"True"}else{"False"});
+			query.append_pair("allowComments",if config.allowComments{"True"}else{"False"});
+			if let Some(group_id)=config.groupId{
+				query.append_pair("groupId",group_id.to_string().as_str());
+			}
+		}
+
+		self.post(url,body).await.map_err(CreateError::PostError)?
+		.error_for_status().map_err(CreateError::Reqwest)?
+		.json::<UploadResponse>().await.map_err(CreateError::Reqwest)
+	}
+	pub async fn upload(&self,config:UploadRequest,body:impl Into<reqwest::Body>+Clone)->Result<UploadResponse,UploadError>{
+		let mut url=reqwest::Url::parse("https://data.roblox.com/Data/Upload.ashx?json=1&type=Model&genreTypeId=1").map_err(UploadError::ParseError)?;
+		//url borrow scope
+		{
+			let mut query=url.query_pairs_mut();//borrow here
+			//archaic roblox api uses 0 for new asset
+			match config.assetid{
+				0=>return Err(UploadError::AssetIdIsZero),
+				assetid=>{query.append_pair("assetid",assetid.to_string().as_str());},
+			}
+			if let Some(name)=config.name.as_deref(){
+				query.append_pair("name",name);
+			}
+			if let Some(description)=config.description.as_deref(){
+				query.append_pair("description",description);
+			}
+			if let Some(ispublic)=config.ispublic{
+				query.append_pair("ispublic",if ispublic{"True"}else{"False"});
+			}
+			if let Some(allow_comments)=config.allowComments{
+				query.append_pair("allowComments",if allow_comments{"True"}else{"False"});
+			}
+			if let Some(group_id)=config.groupId{
+				query.append_pair("groupId",group_id.to_string().as_str());
+			}
+		}
+
+		self.post(url,body).await.map_err(UploadError::PostError)?
+		.error_for_status().map_err(UploadError::Reqwest)?
+		.json::<UploadResponse>().await.map_err(UploadError::Reqwest)
+	}
+	pub async fn get_asset(&self,config:GetAssetRequest)->Result<Vec<u8>,GetError>{
+		let mut url=reqwest::Url::parse("https://assetdelivery.roblox.com/v1/asset/").map_err(GetError::ParseError)?;
+		//url borrow scope
+		{
+			let mut query=url.query_pairs_mut();//borrow here
+			query.append_pair("ID",config.asset_id.to_string().as_str());
+			if let Some(version)=config.version{
+				query.append_pair("version",version.to_string().as_str());
+			}
+		}
+		let body=self.get(url).await.map_err(GetError::Reqwest)?
+		.error_for_status().map_err(GetError::Reqwest)?
+		.bytes().await.map_err(GetError::Reqwest)?;
+
+		match maybe_gzip_decode(&mut std::io::Cursor::new(body)){
+			Ok(ReaderType::GZip(readable))=>read_readable(readable),
+			Ok(ReaderType::Raw(readable))=>read_readable(readable),
+			Err(e)=>Err(e),
+		}.map_err(GetError::IO)
+	}
+	pub async fn get_asset_versions_page(&self,config:AssetVersionsPageRequest)->Result<AssetVersionsPageResponse,AssetVersionsPageError>{
+		let mut url=reqwest::Url::parse(format!("https://develop.roblox.com/v1/assets/{}/saved-versions",config.asset_id).as_str()).map_err(AssetVersionsPageError::ParseError)?;
+		//url borrow scope
+		{
+			let mut query=url.query_pairs_mut();//borrow here
+			//query.append_pair("sortOrder","Asc");
+			//query.append_pair("limit","100");
+			//query.append_pair("count","100");
+			if let Some(cursor)=config.cursor.as_deref(){
+				query.append_pair("cursor",cursor);
+			}
+		}
+
+		self.get(url).await.map_err(AssetVersionsPageError::Reqwest)?
+		.error_for_status().map_err(AssetVersionsPageError::Reqwest)?
+		.json::<AssetVersionsPageResponse>().await.map_err(AssetVersionsPageError::Reqwest)
+	}
+	pub async fn get_inventory_page(&self,config:InventoryPageRequest)->Result<InventoryPageResponse,InventoryPageError>{
+		let mut url=reqwest::Url::parse(format!("https://apis.roblox.com/toolbox-service/v1/creations/group/{}/10?limit=50",config.group).as_str()).map_err(InventoryPageError::ParseError)?;
+		//url borrow scope
+		{
+			let mut query=url.query_pairs_mut();//borrow here
+			if let Some(cursor)=config.cursor.as_deref(){
+				query.append_pair("cursor",cursor);
+			}
+		}
+
+		self.get(url).await.map_err(InventoryPageError::Reqwest)?
+		.error_for_status().map_err(InventoryPageError::Reqwest)?
+		.json::<InventoryPageResponse>().await.map_err(InventoryPageError::Reqwest)
+	}
+}

rbx_asset/src/lib.rs

@@ -1 +1,2 @@
-pub mod context;
+pub mod cloud;
+pub mod cookie;

rox_compiler/src/common.rs

@@ -19,15 +19,15 @@ impl PropertiesOverride{
 impl std::fmt::Display for PropertiesOverride{
 	fn fmt(&self,f:&mut std::fmt::Formatter<'_>)->std::fmt::Result{
 		if let Some(name)=self.name.as_deref(){
-			writeln!(f,"--!Properties.Name = \"{}\"",name)?;
+			writeln!(f,"-- Properties.Name = \"{}\"",name)?;
 		}
 		if let Some(class)=self.class.as_deref(){
-			writeln!(f,"--!Properties.ClassName = \"{}\"",class)?;
+			writeln!(f,"-- Properties.ClassName = \"{}\"",class)?;
 		}
 		Ok(())
 	}
 }
 
-pub(crate) fn sanitize<'a>(s:&'a str)->std::borrow::Cow<'a,str>{
+pub(crate) fn sanitize(s:&str)->std::borrow::Cow<'_,str>{
-	lazy_regex::regex!(r"[^A-z0-9.-]").replace_all(s,"_")
+	lazy_regex::regex!(r"[^A-Za-z0-9.-]").replace_all(s,"_")
 }

rox_compiler/src/compile.rs

@@ -1,4 +1,4 @@
-use std::path::PathBuf;
+use std::path::{Path,PathBuf};
 use futures::{StreamExt, TryStreamExt};
 use tokio::io::AsyncReadExt;
 
@@ -55,9 +55,9 @@ struct QuerySingle{
 	script:QueryHandle,
 }
 impl QuerySingle{
-	fn rox(search_path:&PathBuf,search_name:&str)->Self{
+	fn rox(search_path:&Path,search_name:&str)->Self{
 		Self{
-			script:tokio::spawn(get_file_async(search_path.clone(),format!("{}.lua",search_name)))
+			script:tokio::spawn(get_file_async(search_path.to_owned(),format!("{}.lua",search_name)))
 		}
 	}
 }
@@ -76,7 +76,7 @@ struct QueryTriple{
 	client:QueryHandle,
 }
 impl QueryTriple{
-	fn rox_rojo(search_path:&PathBuf,search_name:&str,search_module:bool)->Self{
+	fn rox_rojo(search_path:&Path,search_name:&str,search_module:bool)->Self{
 		//this should be implemented as constructors of Triplet and Quadruplet to fully support Trey's suggestion
 		let module_name=if search_module{
 			format!("{}.module.lua",search_name)
@@ -84,12 +84,12 @@ impl QueryTriple{
 			format!("{}.lua",search_name)
 		};
 		Self{
-			module:tokio::spawn(get_file_async(search_path.clone(),module_name)),
+			module:tokio::spawn(get_file_async(search_path.to_owned(),module_name)),
-			server:tokio::spawn(get_file_async(search_path.clone(),format!("{}.server.lua",search_name))),
+			server:tokio::spawn(get_file_async(search_path.to_owned(),format!("{}.server.lua",search_name))),
-			client:tokio::spawn(get_file_async(search_path.clone(),format!("{}.client.lua",search_name))),
+			client:tokio::spawn(get_file_async(search_path.to_owned(),format!("{}.client.lua",search_name))),
 		}
 	}
-	fn rojo(search_path:&PathBuf)->Self{
+	fn rojo(search_path:&Path)->Self{
 		QueryTriple::rox_rojo(search_path,"init",false)
 	}
 }
@@ -146,9 +146,9 @@ impl Query for QueryTriple{
 	async fn resolve(self)->QueryHintResult{
 		let (module,server,client)=tokio::join!(self.module,self.server,self.client);
 		mega_triple_join((
-			module.map_err(|e|QueryResolveError::JoinError(e))?.map(|file|FileHint{file,hint:ScriptHint::ModuleScript}),
+			module.map_err(QueryResolveError::JoinError)?.map(|file|FileHint{file,hint:ScriptHint::ModuleScript}),
-			server.map_err(|e|QueryResolveError::JoinError(e))?.map(|file|FileHint{file,hint:ScriptHint::Script}),
+			server.map_err(QueryResolveError::JoinError)?.map(|file|FileHint{file,hint:ScriptHint::Script}),
-			client.map_err(|e|QueryResolveError::JoinError(e))?.map(|file|FileHint{file,hint:ScriptHint::LocalScript}),
+			client.map_err(QueryResolveError::JoinError)?.map(|file|FileHint{file,hint:ScriptHint::LocalScript}),
 		))
 	}
 }
@@ -159,7 +159,7 @@ struct QueryQuad{
 	client:QueryHandle,
 }
 impl QueryQuad{
-	fn rox_rojo(search_path:&PathBuf,search_name:&str)->Self{
+	fn rox_rojo(search_path:&Path,search_name:&str)->Self{
 		let fill=QueryTriple::rox_rojo(search_path,search_name,true);
 		Self{
 			module_implicit:QuerySingle::rox(search_path,search_name).script,//Script.lua
@@ -173,10 +173,10 @@ impl Query for QueryQuad{
 	async fn resolve(self)->QueryHintResult{
 		let (module_implicit,module_explicit,server,client)=tokio::join!(self.module_implicit,self.module_explicit,self.server,self.client);
 		mega_quadruple_join((
-			module_implicit.map_err(|e|QueryResolveError::JoinError(e))?.map(|file|FileHint{file,hint:ScriptHint::ModuleScript}),
+			module_implicit.map_err(QueryResolveError::JoinError)?.map(|file|FileHint{file,hint:ScriptHint::ModuleScript}),
-			module_explicit.map_err(|e|QueryResolveError::JoinError(e))?.map(|file|FileHint{file,hint:ScriptHint::ModuleScript}),
+			module_explicit.map_err(QueryResolveError::JoinError)?.map(|file|FileHint{file,hint:ScriptHint::ModuleScript}),
-			server.map_err(|e|QueryResolveError::JoinError(e))?.map(|file|FileHint{file,hint:ScriptHint::Script}),
+			server.map_err(QueryResolveError::JoinError)?.map(|file|FileHint{file,hint:ScriptHint::Script}),
-			client.map_err(|e|QueryResolveError::JoinError(e))?.map(|file|FileHint{file,hint:ScriptHint::LocalScript}),
+			client.map_err(QueryResolveError::JoinError)?.map(|file|FileHint{file,hint:ScriptHint::LocalScript}),
 		))
 	}
 }
@@ -203,7 +203,7 @@ impl ScriptWithOverrides{
 		let mut count=0;
 		for line in source.lines(){
 			//only string type properties are supported atm
-			if let Some(captures)=lazy_regex::regex!(r#"^\-\-\!\s*Properties\.([A-z]\w*)\s*\=\s*"(\w+)"$"#)
+			if let Some(captures)=lazy_regex::regex!(r#"^\-\-\s*Properties\.([A-Za-z]\w*)\s*\=\s*"(\w+)"$"#)
 			.captures(line){
 				count+=line.len();
 				match &captures[1]{
@@ -248,7 +248,7 @@ pub enum CompileNodeError{
 		extension:String,
 		style:Option<Style>,
 	},
-	NoExtension,
+	UnknownExtension,
 }
 impl std::fmt::Display for CompileNodeError{
 	fn fmt(&self,f:&mut std::fmt::Formatter<'_>)->std::fmt::Result{
@@ -338,12 +338,9 @@ impl CompileNode{
 		.into_string()
 		.map_err(CompileNodeError::FileName)?;
 		//reject goobers
-		let is_goober=match style{
+		let is_goober=matches!(style,Some(Style::Rojo));
-			Some(Style::Rojo)=>true,
-			_=>false,
-		};
 		let (ext_len,file_discernment)={
-			if let Some(captures)=lazy_regex::regex!(r"^.*(.module.lua|.client.lua|.server.lua|.rbxmx|.lua)$")
+			if let Some(captures)=lazy_regex::regex!(r"^.*(\.module\.lua|\.client\.lua|\.server\.lua)$")
 			.captures(file_name.as_str()){
 				let ext=&captures[1];
 				(ext.len(),match ext{
@@ -355,6 +352,12 @@ impl CompileNode{
 					},
 					".client.lua"=>FileDiscernment::Script(ScriptHint::LocalScript),
 					".server.lua"=>FileDiscernment::Script(ScriptHint::Script),
+					_=>panic!("Regex failed"),
+				})
+			}else if let Some(captures)=lazy_regex::regex!(r"^.*(\.rbxmx|\.lua)$")
+			.captures(file_name.as_str()){
+				let ext=&captures[1];
+				(ext.len(),match ext{
 					".rbxmx"=>{
 						if is_goober{
 							Err(CompileNodeError::ExtensionNotSupportedInStyle{extension:ext.to_owned(),style})?;
@@ -365,7 +368,7 @@ impl CompileNode{
 					_=>panic!("Regex failed"),
 				})
 			}else{
-				return Err(CompileNodeError::NoExtension);
+				return Err(CompileNodeError::UnknownExtension);
 			}
 		};
 		file_name.truncate(file_name.len()-ext_len);
@@ -433,7 +436,7 @@ impl std::error::Error for CompileError{}
 
 pub async fn compile(config:CompileConfig,mut dom:&mut rbx_dom_weak::WeakDom)->Result<(),CompileError>{
 	//hack to traverse root folder as the root object
-	dom.root_mut().name="src".to_owned();
+	"src".clone_into(&mut dom.root_mut().name);
 	//add in scripts and models
 	let mut folder=config.input_folder.clone();
 	let mut stack:Vec<CompileStackInstruction>=vec![CompileStackInstruction::TraverseReferent(dom.root_ref(),None)];
@@ -453,9 +456,9 @@ pub async fn compile(config:CompileConfig,mut dom:&mut rbx_dom_weak::WeakDom)->R
 					let mut exist_names:std::collections::HashSet<String>={
 						let item=dom.get_by_ref(item_ref).ok_or(CompileError::NullChildRef)?;
 						//push existing dom children objects onto stack (unrelated to exist_names)
-						stack.extend(item.children().into_iter().map(|&referent|CompileStackInstruction::TraverseReferent(referent,None)));
+						stack.extend(item.children().iter().map(|&referent|CompileStackInstruction::TraverseReferent(referent,None)));
 						//get names of existing objects
-						item.children().into_iter().map(|&child_ref|{
+						item.children().iter().map(|&child_ref|{
 							let child=dom.get_by_ref(child_ref).ok_or(CompileError::NullChildRef)?;
 							Ok::<_,CompileError>(sanitize(child.name.as_str()).to_string())
 						}).collect::<Result<_,CompileError>>()?
@@ -472,7 +475,7 @@ pub async fn compile(config:CompileConfig,mut dom:&mut rbx_dom_weak::WeakDom)->R
 						let ret1={
 							//capture a scoped mutable reference so we can forward dir to the next call even on an error
 							let dir2=&mut dir1;
-							(||async move{//error catcher so I can use ?
+							async move{//error catcher so I can use ?
 								let ret2=if let Some(entry)=dir2.next_entry().await?{
 									//cull early even if supporting things with identical names is possible
 									if exist_names.contains(entry.file_name().to_str().unwrap()){
@@ -484,7 +487,7 @@ pub async fn compile(config:CompileConfig,mut dom:&mut rbx_dom_weak::WeakDom)->R
 									TooComplicated::Stop
 								};
 								Ok(ret2)
-							})().await
+							}.await
 						};
 						match ret1{
 							Ok(TooComplicated::Stop)=>None,
@@ -500,10 +503,19 @@ pub async fn compile(config:CompileConfig,mut dom:&mut rbx_dom_weak::WeakDom)->R
 							Ok(Some(entry))=>tokio::spawn(async move{
 								let met=entry.metadata().await.map_err(CompileError::IO)?;
 								//discern that bad boy
-								let compile_class=match met.is_dir(){
+								let compile_class={
+									let result=match met.is_dir(){
 										true=>CompileNode::from_folder(&entry,style).await,
 										false=>CompileNode::from_file(&entry,style).await,
-								}.map_err(CompileError::CompileNode)?;
+									};
+									match result{
+										Ok(compile_class)=>compile_class,
+										Err(e)=>{
+											println!("Ignoring file {entry:?} due to error {e}");
+											return Ok(None);
+										},
+									}
+								};
 								//prepare data structure
 								Ok(Some((compile_class.blacklist,match compile_class.class{
 									CompileClass::Folder=>PreparedData::Builder(rbx_dom_weak::InstanceBuilder::new("Folder").with_name(compile_class.name.as_str())),
@@ -525,8 +537,7 @@ pub async fn compile(config:CompileConfig,mut dom:&mut rbx_dom_weak::WeakDom)->R
 					//TODO: fix dom being &mut &mut inside the closure
 					.try_fold((&mut stack,&mut dom),|(stack,dom),bog|async{
 						//push child objects onto dom serially as they arrive
-						match bog{
+						if let Some((blacklist,data))=bog{
-							Some((blacklist,data))=>{
 							let referent=match data{
 								PreparedData::Model(mut model_dom)=>{
 									let referent=model_dom.root().children()[0];
@@ -537,8 +548,6 @@ pub async fn compile(config:CompileConfig,mut dom:&mut rbx_dom_weak::WeakDom)->R
 							};
 							//new children need to be traversed
 							stack.push(CompileStackInstruction::TraverseReferent(referent,blacklist));
-							},
-							None=>(),
 						}
 						Ok((stack,dom))
 					}).await?;
@@ -547,5 +556,5 @@ pub async fn compile(config:CompileConfig,mut dom:&mut rbx_dom_weak::WeakDom)->R
 			CompileStackInstruction::PopFolder=>assert!(folder.pop(),"pop folder bad"),
 		}
 	}
-	unreachable!();
+	Ok(())
 }

rox_compiler/src/decompile.rs

@@ -147,10 +147,7 @@ impl DecompiledContext{
 				"Model"=>Class::Model,
 				_=>Class::Folder,
 			};
-			let skip=match class{
+			let skip=class==Class::Model;
-				Class::Model=>true,
-				_=>false,
-			};
 			if let Some(parent_node)=tree_refs.get_mut(&item.parent()){
 				let referent=item.referent();
 				let node=TreeNode::new(item.name.clone(),referent,parent_node.referent,class);
@@ -182,14 +179,14 @@ impl DecompiledContext{
 						if node.class==Class::Folder&&script_count!=0{
 							node.class=Class::Model
 						}
-						if node.class==Class::Folder&&node.children.len()==0{
+						if node.class==Class::Folder&&node.children.is_empty(){
 							delete=Some(node.parent);
 						}else{
 							//how the hell do I do this better without recursion
-							let is_script=match node.class{
+							let is_script=matches!(
-								Class::ModuleScript|Class::LocalScript|Class::Script=>true,
+								node.class,
-								_=>false,
+								Class::ModuleScript|Class::LocalScript|Class::Script
-							};
+							);
 							//stack is popped from back
 							if is_script{
 								stack.push(TrimStackInstruction::DecrementScript);
@@ -237,7 +234,7 @@ impl DecompiledContext{
 				WriteStackInstruction::Node(node,name_count)=>{
 					//track properties that must be overriden to compile folder structure back into a place file
 					let mut properties=PropertiesOverride::default();
-					let has_children=node.children.len()!=0;
+					let has_children=!node.children.is_empty();
 					match node.class{
 						Class::Folder=>(),
 						Class::ModuleScript=>(),//.lua files are ModuleScript by default
@@ -297,7 +294,7 @@ impl DecompiledContext{
 			let write_models=config.write_models;
 			let write_scripts=config.write_scripts;
 			let results:Vec<Result<(),WriteError>>=rayon::iter::ParallelIterator::collect(rayon::iter::ParallelIterator::map(rayon::iter::IntoParallelIterator::into_par_iter(write_queue),|(write_path,node,node_name_override,properties,style)|{
-				write_item(&dom,write_path,node,node_name_override,properties,style,write_models,write_scripts)
+				write_item(dom,write_path,node,node_name_override,properties,style,write_models,write_scripts)
 			}));
 			for result in results{
 				result?;