fixed

wrong function bruh
walk the class tree, return the first function found
2024-10-05 21:01:47 -07:00 · 2024-10-05 20:19:46 -07:00 · 2024-10-05 20:06:58 -07:00 · 2024-10-05 19:58:40 -07:00 · 2024-10-05 19:41:38 -07:00
8 changed files with 215 additions and 117 deletions
--- a/Cargo.lock
+++ b/Cargo.lock
@ -32,6 +32,12 @@ version = "1.3.2"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "bef38d45163c2f1dde094a7dfd33ccf595c92905c8f8f4fdc18d06fb1037718a"

+[[package]]
+name = "bitflags"
+version = "2.6.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "b048fb63fd8b5923fc5aa7b340d8e156aec7ec02f0c78fa8a6ddc2613f6f71de"
+
 [[package]]
 name = "blake3"
 version = "1.5.4"
@ -121,6 +127,16 @@ dependencies = [
 "windows-targets",
 ]

+[[package]]
+name = "lock_api"
+version = "0.4.12"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "07af8b9cdd281b7915f413fa73f29ebd5d55d0d3f0155584dade1ff18cea1b17"
+dependencies = [
+ "autocfg",
+ "scopeguard",
+]
+
 [[package]]
 name = "luau0-src"
 version = "0.10.3+luau640"
@ -138,15 +154,15 @@ checksum = "78ca9ab1a0babb1e7d5695e3530886289c18cf2f87ec19a575a0abdce112e3a3"

 [[package]]
 name = "mlua"
-version = "0.9.9"
+version = "0.10.0-beta.2"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "d111deb18a9c9bd33e1541309f4742523bfab01d276bfa9a27519f6de9c11dc7"
+checksum = "200dd4c8e5f81416d43a023b9921c3cbf01d828094b23a90b26826c3840ba4f3"
 dependencies = [
 "bstr",
 "libloading",
 "mlua-sys",
 "num-traits",
- "once_cell",
+ "parking_lot",
 "rustc-hash",
 ]

@ -172,10 +188,27 @@ dependencies = [
 ]

 [[package]]
-name = "once_cell"
-version = "1.19.0"
+name = "parking_lot"
+version = "0.12.3"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "3fdb12b2476b595f9358c5161aa467c2438859caa136dec86c26fdd2efe17b92"
+checksum = "f1bf18183cf54e8d6059647fc3063646a1801cf30896933ec2311622cc4b9a27"
+dependencies = [
+ "lock_api",
+ "parking_lot_core",
+]
+
+[[package]]
+name = "parking_lot_core"
+version = "0.9.10"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "1e401f977ab385c9e4e3ab30627d6f26d00e2c73eef317493c4ec6d468726cf8"
+dependencies = [
+ "cfg-if",
+ "libc",
+ "redox_syscall",
+ "smallvec",
+ "windows-targets",
+]

 [[package]]
 name = "paste"
@ -328,7 +361,7 @@ source = "sparse+https://git.itzana.me/api/packages/strafesnet/cargo/"
 checksum = "d7a390c44034fa448c53bd0983dfc2d70d8d6b2f65be4f164d4bec8b6a2a2d09"
 dependencies = [
 "base64",
- "bitflags",
+ "bitflags 1.3.2",
 "blake3",
 "lazy_static",
 "rand",
@ -336,6 +369,15 @@ dependencies = [
 "thiserror",
 ]

+[[package]]
+name = "redox_syscall"
+version = "0.5.7"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "9b6dfecf2c74bce2466cabf93f6664d6998a69eb21e39f4207930065b27b771f"
+dependencies = [
+ "bitflags 2.6.0",
+]
+
 [[package]]
 name = "rmp"
 version = "0.8.14"
@ -377,6 +419,12 @@ version = "2.0.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "583034fd73374156e66797ed8e5b0d5690409c9226b22d87cb7f19821c05d152"

+[[package]]
+name = "scopeguard"
+version = "1.2.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "94143f37725109f92c262ed2cf5e59bce7498c01bcc1502d7b9afe439a4e9f49"
+
 [[package]]
 name = "serde"
 version = "1.0.210"
@ -409,6 +457,12 @@ version = "0.3.11"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "38b58827f4464d87d377d175e90bf58eb00fd8716ff0a62f80356b5e61555d0d"

+[[package]]
+name = "smallvec"
+version = "1.13.2"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "3c5e1a9a646d36c3599cd173a41282daf47c44583ad367b8e6837255952e5c67"
+
 [[package]]
 name = "syn"
 version = "2.0.77"
--- a/Cargo.toml
+++ b/Cargo.toml
@ -9,7 +9,7 @@ authors = ["Rhys Lloyd <krakow20@gmail.com>"]

 [dependencies]
 glam = "0.29.0"
-mlua = { version = "0.9.9", features = ["luau"] }
+mlua = { version = "0.10.0-beta", features = ["luau"] }
 phf = { version = "0.11.2", features = ["macros"] }
 rbx_dom_weak = { version = "2.7.0", registry = "strafesnet" }
 rbx_reflection = { version = "4.7.0", registry = "strafesnet" }
--- a/src/runner/cframe.rs
+++ b/src/runner/cframe.rs
@ -59,7 +59,7 @@ impl From<rbx_types::CFrame> for CFrame{
 	}
 }

-pub fn set_globals(lua:&mlua::Lua,globals:&mlua::Table<'_>)->Result<(),mlua::Error>{
+pub fn set_globals(lua:&mlua::Lua,globals:&mlua::Table)->Result<(),mlua::Error>{
 	let cframe_table=lua.create_table()?;

 	//CFrame.new
@ -126,12 +126,12 @@ pub fn set_globals(lua:&mlua::Lua,globals:&mlua::Table<'_>)->Result<(),mlua::Err
 }

 impl mlua::UserData for CFrame{
-	fn add_fields<'lua,F:mlua::UserDataFields<'lua,Self>>(fields:&mut F){
+	fn add_fields<F:mlua::UserDataFields<Self>>(fields:&mut F){
 		//CFrame.p
 		fields.add_field_method_get("p",|_,this|Ok(Vector3(this.0.translation)));
 	}

-	fn add_methods<'lua,M:mlua::UserDataMethods<'lua,Self>>(methods:&mut M){
+	fn add_methods<M:mlua::UserDataMethods<Self>>(methods:&mut M){
 		methods.add_method("components",|_,this,()|Ok((
 			this.0.translation.x,
 			this.0.translation.y,
--- a/src/runner/color3.rs
+++ b/src/runner/color3.rs
@ -15,7 +15,7 @@ impl Into<rbx_types::Color3> for Color3{
 	}
 }

-pub fn set_globals(lua:&mlua::Lua,globals:&mlua::Table<'_>)->Result<(),mlua::Error>{
+pub fn set_globals(lua:&mlua::Lua,globals:&mlua::Table)->Result<(),mlua::Error>{
 	let color3_table=lua.create_table()?;

 	color3_table.raw_set("new",
@ -38,7 +38,7 @@ fn lerp(lhs:f32,rhs:f32,t:f32)->f32{
 }

 impl mlua::UserData for Color3{
-	fn add_fields<'lua,F:mlua::UserDataFields<'lua,Self>>(fields:&mut F){
+	fn add_fields<F:mlua::UserDataFields<Self>>(fields:&mut F){
 		fields.add_field_method_get("r",|_,this|Ok(this.r));
 		fields.add_field_method_set("r",|_,this,val|{
 			this.r=val;
@ -55,7 +55,7 @@ impl mlua::UserData for Color3{
 			Ok(())
 		});
 	}
-	fn add_methods<'lua,M:mlua::UserDataMethods<'lua,Self>>(methods:&mut M){
+	fn add_methods<M:mlua::UserDataMethods<Self>>(methods:&mut M){
 		methods.add_method("Lerp",|_,this,(other,t):(Self,f32)|
 			Ok(Color3::new(
 				lerp(this.r,other.r,t),
--- a/src/runner/enum.rs
+++ b/src/runner/enum.rs
@ -2,7 +2,9 @@ use mlua::IntoLua;

 #[derive(Clone,Copy)]
 pub struct Enum(u32);
+#[derive(Clone,Copy)]
 pub struct EnumItems;
+#[derive(Clone,Copy)]
 pub struct EnumItem<'a>{
 	ed:&'a rbx_reflection::EnumDescriptor<'a>,
 }
@ -19,16 +21,16 @@ impl<'a> EnumItem<'a>{
 	}
 }

-pub fn set_globals(_lua:&mlua::Lua,globals:&mlua::Table<'_>)->Result<(),mlua::Error>{
+pub fn set_globals(_lua:&mlua::Lua,globals:&mlua::Table)->Result<(),mlua::Error>{
 	globals.set("Enum",EnumItems)
 }

 impl mlua::UserData for EnumItem<'_>{
-	fn add_fields<'lua,F:mlua::UserDataFields<'lua,Self>>(_fields:&mut F){
+	fn add_fields<F:mlua::UserDataFields<Self>>(_fields:&mut F){
 	}
-	fn add_methods<'lua,M:mlua::UserDataMethods<'lua,Self>>(methods:&mut M){
-		methods.add_meta_function(mlua::MetaMethod::Index,|lua,(this,val):(EnumItem<'lua>,mlua::String)|{
-			match this.ed.items.get(val.to_str()?){
+	fn add_methods<M:mlua::UserDataMethods<Self>>(methods:&mut M){
+		methods.add_meta_function(mlua::MetaMethod::Index,|lua,(this,val):(EnumItem<'_>,mlua::String)|{
+			match this.ed.items.get(&*val.to_str()?){
 				Some(&id)=>Enum(id).into_lua(lua),
 				None=>mlua::Value::Nil.into_lua(lua),
 			}
@ -38,12 +40,12 @@ impl mlua::UserData for EnumItem<'_>{
 type_from_lua_userdata_lua_lifetime!(EnumItem);

 impl mlua::UserData for EnumItems{
-	fn add_fields<'lua,F:mlua::UserDataFields<'lua,Self>>(_fields:&mut F){
+	fn add_fields<F:mlua::UserDataFields<Self>>(_fields:&mut F){
 	}
-	fn add_methods<'lua,M:mlua::UserDataMethods<'lua,Self>>(methods:&mut M){
+	fn add_methods<M:mlua::UserDataMethods<Self>>(methods:&mut M){
 		methods.add_meta_function(mlua::MetaMethod::Index,|lua,(_,val):(Self,mlua::String)|{
 			let db=rbx_reflection_database::get();
-			match db.enums.get(val.to_str()?){
+			match db.enums.get(&*val.to_str()?){
 				Some(ed)=>EnumItem::new(ed).into_lua(lua),
 				None=>mlua::Value::Nil.into_lua(lua),
 			}
@ -53,9 +55,9 @@ impl mlua::UserData for EnumItems{
 type_from_lua_userdata!(EnumItems);

 impl mlua::UserData for Enum{
-	fn add_fields<'lua,F:mlua::UserDataFields<'lua,Self>>(_fields:&mut F){
+	fn add_fields<F:mlua::UserDataFields<Self>>(_fields:&mut F){
 	}
-	fn add_methods<'lua,M:mlua::UserDataMethods<'lua,Self>>(_methods:&mut M){
+	fn add_methods<M:mlua::UserDataMethods<Self>>(_methods:&mut M){
 	}
 }
 type_from_lua_userdata!(Enum);
--- a/src/runner/instance.rs
+++ b/src/runner/instance.rs
@ -1,42 +1,23 @@
 use std::collections::{hash_map::Entry,HashMap};

-use mlua::{IntoLua,IntoLuaMulti};
+use mlua::{FromLuaMulti,IntoLua,IntoLuaMulti};
 use rbx_types::Ref;
 use rbx_dom_weak::{InstanceBuilder,WeakDom};

 use super::vector3::Vector3;

-/// A store of created functions for each Roblox class.
-/// Functions are created the first time they are accessed and stored in this data structure.
-#[derive(Default)]
-struct ClassFunctions<'a>{
-	classes:HashMap<&'static str,//ClassName
-		HashMap<&'static str,//Function name
-			mlua::Function<'a>
-		>
-	>
-}
-
-fn place_id<'lua>(lua:&'lua mlua::Lua,tuple:mlua::MultiValue<'lua>)->mlua::Result<mlua::MultiValue<'lua>>{
-	0.into_lua_multi(lua)
-}
-type FPointer=for<'lua> fn(&'lua mlua::Lua,mlua::MultiValue<'lua>)->mlua::Result<mlua::MultiValue<'lua>>;
-static CLASS_FUNCTION_DATABASE:phf::Map<&str,phf::Map<&str,FPointer>>=phf::phf_map!{
-	"DataModel"=>phf::phf_map!{
-		"GetService"=>place_id as FPointer,
-	}
-};
-
-pub fn set_globals(lua:&mlua::Lua,globals:&mlua::Table<'_>)->Result<(),mlua::Error>{
+pub fn set_globals(lua:&mlua::Lua,globals:&mlua::Table)->Result<(),mlua::Error>{
 	//class functions store
-	lua.set_app_data::<ClassFunctions<'static>>(ClassFunctions::default());
+	lua.set_app_data(ClassFunctions::default());
+
+	lua.register_userdata_type(<Instance as mlua::UserData>::register)?;

 	let instance_table=lua.create_table()?;

 	//Instance.new
 	instance_table.raw_set("new",
 		lua.create_function(|lua,(class_name,parent):(mlua::String,Option<Instance>)|{
-			let class_name_str=class_name.to_str()?;
+			let class_name_str=&*class_name.to_str()?;
 			let parent=parent.ok_or(mlua::Error::runtime("Nil Parent not yet supported"))?;
 			dom_mut(lua,|dom|{
 				//TODO: Nil instances
@ -55,9 +36,9 @@ fn dom_mut<T>(lua:&mlua::Lua,mut f:impl FnMut(&mut WeakDom)->mlua::Result<T>)->m
 	let mut dom=lua.app_data_mut::<&'static mut WeakDom>().ok_or(mlua::Error::runtime("DataModel missing"))?;
 	f(&mut *dom)
 }
-fn class_functions_mut<T>(lua:&mlua::Lua,mut f:impl FnMut(&mut ClassFunctions<'_>)->mlua::Result<T>)->mlua::Result<T>{
-	let mut dom=lua.app_data_mut::<ClassFunctions<'static>>().ok_or(mlua::Error::runtime("ClassFunctions missing"))?;
-	f(&mut *dom)
+fn class_functions_mut<T>(lua:&mlua::Lua,mut f:impl FnMut(&mut ClassFunctions)->mlua::Result<T>)->mlua::Result<T>{
+	let mut cf=lua.app_data_mut::<ClassFunctions>().ok_or(mlua::Error::runtime("ClassFunctions missing"))?;
+	f(&mut *cf)
 }

 fn coerce_float32(value:&mlua::Value)->Option<f32>{
@ -141,7 +122,7 @@ impl<'a> Iterator for SuperClassIter<'a> {
 }

 impl mlua::UserData for Instance{
-	fn add_fields<'lua,F:mlua::UserDataFields<'lua,Self>>(fields:&mut F){
+	fn add_fields<F:mlua::UserDataFields<Self>>(fields:&mut F){
 		fields.add_field_method_get("Parent",|lua,this|{
 			dom_mut(lua,|dom|{
 				let instance=this.get(dom)?;
@ -176,7 +157,7 @@ impl mlua::UserData for Instance{
 			})
 		});
 	}
-	fn add_methods<'lua,M:mlua::UserDataMethods<'lua,Self>>(methods:&mut M){
+	fn add_methods<M:mlua::UserDataMethods<Self>>(methods:&mut M){
 		methods.add_method("GetChildren",|lua,this,_:()|
 			dom_mut(lua,|dom|{
 				let instance=this.get(dom)?;
@ -189,8 +170,8 @@ impl mlua::UserData for Instance{
 				Ok(children)
 			})
 		);
-		let ffc=|lua,this:&Self,(name,search_descendants):(mlua::String,Option<bool>)|{
-			let name_str=name.to_str()?;
+		fn ffc(lua:&mlua::Lua,this:&Instance,(name,search_descendants):(mlua::String,Option<bool>))->mlua::Result<Option<Instance>>{
+			let name_str=&*name.to_str()?;
 			dom_mut(lua,|dom|{
 				let instance=this.get(dom)?;
 				Ok(
@ -203,11 +184,11 @@ impl mlua::UserData for Instance{
 					)
 				)
 			})
-		};
+		}
 		methods.add_method("FindFirstChild",ffc);
 		methods.add_method("WaitForChild",ffc);
 		methods.add_method("FindFirstChildOfClass",|lua,this,(class,search_descendants):(mlua::String,Option<bool>)|{
-			let class_str=class.to_str()?;
+			let class_str=&*class.to_str()?;
 			dom_mut(lua,|dom|{
 				Ok(
 					match search_descendants.unwrap_or(false){
@ -234,7 +215,7 @@ impl mlua::UserData for Instance{
 		methods.add_method("IsA",|lua,this,classname:mlua::String|
 			dom_mut(lua,|dom|{
 				let instance=this.get(dom)?;
-				Ok(crate::context::class_is_a(instance.class.as_str(),classname.to_str()?))
+				Ok(crate::context::class_is_a(instance.class.as_str(),&*classname.to_str()?))
 			})
 		);
 		methods.add_method("Destroy",|lua,this,()|
@ -243,65 +224,49 @@ impl mlua::UserData for Instance{
 				Ok(())
 			})
 		);
-		methods.add_meta_function(mlua::MetaMethod::Index,|lua,(this,index):(Instance,mlua::String)|{
-			let index_str=index.to_str()?;
+		methods.add_meta_function(mlua::MetaMethod::ToString,|lua,this:Instance|{
 			dom_mut(lua,|dom|{
 				let instance=this.get(dom)?;
+				Ok(instance.name.clone())
+			})
+		});
+		methods.add_meta_function(mlua::MetaMethod::Index,|lua,(this,index):(Instance,mlua::String)|{
+			let index_str=&*index.to_str()?;
+			dom_mut(lua,|dom|{
+				let instance=this.get(dom)?;
+				//println!("__index t={} i={index:?}",instance.name);
+				let db=rbx_reflection_database::get();
+				let class=db.classes.get(instance.class.as_str()).ok_or(mlua::Error::runtime("Class missing"))?;
 				//Find existing property
 				match instance.properties.get(index_str)
 					//Find default value
-					.or_else(||{
-						let db=rbx_reflection_database::get();
-						db.classes.get(instance.class.as_str()).and_then(|cd|
-							db.find_default_property(cd,index_str)
-						)
-					})
+					.or_else(||db.find_default_property(class,index_str))
 				{
+					Some(&rbx_types::Variant::Int32(val))=>return Ok(val.into_lua(lua)),
+					Some(&rbx_types::Variant::Int64(val))=>return Ok(val.into_lua(lua)),
+					Some(&rbx_types::Variant::Float32(val))=>return Ok(val.into_lua(lua)),
+					Some(&rbx_types::Variant::Float64(val))=>return Ok(val.into_lua(lua)),
 					Some(&rbx_types::Variant::CFrame(cf))=>return Ok(Into::<super::cframe::CFrame>::into(cf).into_lua(lua)),
 					Some(&rbx_types::Variant::Vector3(v))=>return Ok(Into::<super::vector3::Vector3>::into(v).into_lua(lua)),
-					_=>(),
+					other=>println!("instance.properties.get(i)={other:?}"),
 				}
 				//find a function with a matching name
-				if let Some(ret)=class_functions_mut(lua,|cf|{
-					let class_str=instance.class.as_str();
-					let f=match CLASS_FUNCTION_DATABASE.get_entry(class_str){
-						Some((&static_class_str,class_functions))=>{
-							match cf.classes.entry(static_class_str){
-								Entry::Occupied(mut occupied_entry)=>{
-									match class_functions.get_entry(index_str){
-										Some((&static_index_str,function_pointer))=>{
-											match occupied_entry.get_mut().entry(static_index_str){
-												Entry::Occupied(occupied_entry)=>{
-													Some(occupied_entry.get().clone())
-												},
-												Entry::Vacant(vacant_entry)=>{
-													Some(vacant_entry.insert(unsafe{core::mem::transmute(lua.create_function(function_pointer)?)}).clone())
-												},
-											}
-										},
-										None=>None,
-									}
-								},
-								Entry::Vacant(vacant_entry)=>{
-									match class_functions.get_entry(index_str){
-										Some((&static_index_str,function_pointer))=>{
-											let mut h=HashMap::new();
-											h.entry(static_index_str).or_insert(unsafe{core::mem::transmute(lua.create_function(function_pointer)?)});
-											vacant_entry.insert(h).get(static_index_str).map(|f|f.clone())
-										},
-										None=>None,
-									}
-								},
-							}
-						},
-						None=>None,
+				if let Some(function)=class_functions_mut(lua,|cf|{
+					let mut iter=SuperClassIter{
+						database:db,
+						descriptor:Some(class),
 					};
-					Ok(f.map(|f|{
-						let f_static:mlua::Function::<'static>=unsafe{core::mem::transmute(f)};
-						f_static
-					}))
+					Ok(loop{
+						match iter.next(){
+							Some(class)=>match cf.get_or_create_class_function(lua,&class.name,index_str)?{
+								Some(function)=>break Some(function),
+								None=>(),
+							},
+							None=>break None,
+						}
+					})
 				})?{
-					return Ok(ret.into_lua(lua));
+					return Ok(function.into_lua(lua));
 				}
 				//find a child with a matching name
 				Ok(
@ -315,7 +280,7 @@ impl mlua::UserData for Instance{
 			dom_mut(lua,|dom|{
 				let instance=this.get_mut(dom)?;
 				//println!("__newindex t={} i={index:?} v={value:?}",instance.name);
-				let index_str=index.to_str()?;
+				let index_str=&*index.to_str()?;
 				let db=rbx_reflection_database::get();
 				let class=db.classes.get(instance.class.as_str()).ok_or(mlua::Error::runtime("Class missing"))?;
 				let mut iter=SuperClassIter{
@ -338,7 +303,7 @@ impl mlua::UserData for Instance{
 							&mlua::Value::Number(num)=>Ok(rbx_types::Enum::from_u32(num as u32)),
 							mlua::Value::String(s)=>{
 								let e=db.enums.get(enum_name).ok_or(mlua::Error::runtime("Database DataType Enum name  does not exist"))?;
-								Ok(rbx_types::Enum::from_u32(*e.items.get(s.to_str()?).ok_or(mlua::Error::runtime("Invalid enum item"))?))
+								Ok(rbx_types::Enum::from_u32(*e.items.get(&*s.to_str()?).ok_or(mlua::Error::runtime("Invalid enum item"))?))
 							},
 							mlua::Value::UserData(any_user_data)=>{
 								let e:super::r#enum::Enum=any_user_data.take()?;
@ -367,3 +332,80 @@ impl mlua::UserData for Instance{
 		});
 	}
 }
+
+fn get_service(lua:&mlua::Lua,tuple:mlua::MultiValue)->mlua::Result<mlua::MultiValue>{
+	let (_game,service):(Instance,mlua::String)=FromLuaMulti::from_lua_multi(tuple,lua)?;
+	dom_mut(lua,|dom|{
+		match &*service.to_str()?{
+			"Lighting"=>{
+				let referent=find_first_child_of_class(dom,dom.root(),"Lighting")
+        				.map(|instance|instance.referent())
+				.unwrap_or_else(||
+					dom.insert(dom.root_ref(),InstanceBuilder::new("Lighting"))
+				);
+				Instance::new(referent).into_lua_multi(lua)
+			},
+			other=>Err::<mlua::MultiValue,_>(mlua::Error::runtime(format!("Service '{other}' not supported"))),
+		}
+	})
+}
+type FPointer=fn(&mlua::Lua,mlua::MultiValue)->mlua::Result<mlua::MultiValue>;
+/// A double hash map of function pointers.
+/// The class tree is walked by the Instance.__index metamethod to find available class methods.
+static CLASS_FUNCTION_DATABASE:phf::Map<&str,phf::Map<&str,FPointer>>=phf::phf_map!{
+	"DataModel"=>phf::phf_map!{
+		"GetService"=>get_service as FPointer,
+	}
+};
+
+/// A store of created functions for each Roblox class.
+/// Functions are created the first time they are accessed and stored in this data structure.
+#[derive(Default)]
+struct ClassFunctions{
+	classes:HashMap<&'static str,//ClassName
+		HashMap<&'static str,//Function name
+			mlua::Function
+		>
+	>
+}
+impl ClassFunctions{
+	/// Someone please rewrite this, all it's supposed to do is
+	/// return self.classes[class][index] or create the function in the hashmap and then return it
+	fn get_or_create_class_function(&mut self,lua:&mlua::Lua,class:&str,index:&str)->mlua::Result<Option<mlua::Function>>{
+		// Use get_entry to get the &'static str key of the database
+		// and use it as a key for the classes hashmap
+		let f=match CLASS_FUNCTION_DATABASE.get_entry(class){
+			Some((&static_class_str,class_functions))=>{
+				match self.classes.entry(static_class_str){
+					Entry::Occupied(mut occupied_entry)=>{
+						match class_functions.get_entry(index){
+							Some((&static_index_str,function_pointer))=>{
+								match occupied_entry.get_mut().entry(static_index_str){
+									Entry::Occupied(occupied_entry)=>{
+										Some(occupied_entry.get().clone())
+									},
+									Entry::Vacant(vacant_entry)=>{
+										Some(vacant_entry.insert(lua.create_function(function_pointer)?).clone())
+									},
+								}
+							},
+							None=>None,
+						}
+					},
+					Entry::Vacant(vacant_entry)=>{
+						match class_functions.get_entry(index){
+							Some((&static_index_str,function_pointer))=>{
+								let mut h=HashMap::new();
+								h.entry(static_index_str).or_insert(lua.create_function(function_pointer)?);
+								vacant_entry.insert(h).get(static_index_str).map(|f|f.clone())
+							},
+							None=>None,
+						}
+					},
+				}
+			},
+			None=>None,
+		};
+		Ok(f)
+	}
+}
--- a/src/runner/macros.rs
+++ b/src/runner/macros.rs
@ -1,9 +1,9 @@
 macro_rules! type_from_lua_userdata{
 	($asd:ident)=>{
-		impl<'lua> mlua::FromLua<'lua> for $asd{
-			fn from_lua(value:mlua::Value<'lua>,_lua:&'lua mlua::Lua)->Result<Self,mlua::Error>{
+		impl mlua::FromLua for $asd{
+			fn from_lua(value:mlua::Value,_lua:&mlua::Lua)->Result<Self,mlua::Error>{
 				match value{
-					mlua::Value::UserData(ud)=>ud.take(),
+					mlua::Value::UserData(ud)=>Ok(*ud.borrow::<Self>()?),
 					other=>Err(mlua::Error::runtime(format!("Expected {} got {:?}",stringify!($asd),other))),
 				}
 			}
@ -12,10 +12,10 @@ macro_rules! type_from_lua_userdata{
 }
 macro_rules! type_from_lua_userdata_lua_lifetime{
 	($asd:ident)=>{
-		impl<'lua> mlua::FromLua<'lua> for $asd<'lua>{
-			fn from_lua(value:mlua::Value<'lua>,_lua:&'lua mlua::Lua)->Result<Self,mlua::Error>{
+		impl mlua::FromLua for $asd<'static>{
+			fn from_lua(value:mlua::Value,_lua:&mlua::Lua)->Result<Self,mlua::Error>{
 				match value{
-					mlua::Value::UserData(ud)=>ud.take(),
+					mlua::Value::UserData(ud)=>Ok(*ud.borrow::<Self>()?),
 					other=>Err(mlua::Error::runtime(format!("Expected {} got {:?}",stringify!($asd),other))),
 				}
 			}
--- a/src/runner/vector3.rs
+++ b/src/runner/vector3.rs
@ -7,7 +7,7 @@ impl Vector3{
 	}
 }

-pub fn set_globals(lua:&mlua::Lua,globals:&mlua::Table<'_>)->Result<(),mlua::Error>{
+pub fn set_globals(lua:&mlua::Lua,globals:&mlua::Table)->Result<(),mlua::Error>{
 	let vector3_table=lua.create_table()?;

 	//Vector3.new
@ -35,7 +35,7 @@ impl From<rbx_types::Vector3> for Vector3{
 }

 impl mlua::UserData for Vector3{
-	fn add_fields<'lua,F: mlua::UserDataFields<'lua,Self>>(fields: &mut F){
+	fn add_fields<F:mlua::UserDataFields<Self>>(fields:&mut F){
 		fields.add_field_method_get("magnitude",|_,this|Ok(this.0.length()));
 		fields.add_field_method_get("x",|_,this|Ok(this.0.x));
 		fields.add_field_method_set("x",|_,this,val|{
@ -54,7 +54,7 @@ impl mlua::UserData for Vector3{
 		});
 	}

-	fn add_methods<'lua,M: mlua::UserDataMethods<'lua,Self>>(methods:&mut M){
+	fn add_methods<M:mlua::UserDataMethods<Self>>(methods:&mut M){
 		//methods.add_method("area",|_,this,()| Ok(this.length * this.width));

 		methods.add_meta_function(mlua::MetaMethod::Add,|_,(this,val):(Self,Self)|Ok(Self(this.0+val.0)));
Author	SHA1	Message	Date
Quaternions	248f8d5b56	fixed	2024-10-05 21:01:47 -07:00
Quaternions	0eff07d22d	wrong function bruh	2024-10-05 20:19:46 -07:00
Quaternions	c47f30054f	walk the class tree, return the first function found	2024-10-05 20:06:58 -07:00
Quaternions	c96d9b7aef	move big chungus to the bottom of the file	2024-10-05 19:58:40 -07:00
Quaternions	5a2c70c2c9	update mlua to 0.10.0-beta	2024-10-05 19:41:38 -07:00