StrafesNET/public-api
5
Fork 0
Code Issues 5 Pull Requests Projects Wiki Activity

Support returning PaginationWithTotal from /times/worldrecord #4

New Issue
Open
opened 2025-06-28 20:29:15 +00:00 by fiveman1 · 1 comment
fiveman1 commented 2025-06-28 20:29:15 +00:00
Copy Link

It would be very nice if /times/worldrecord supported returning the total items/pages in the response, particularly if a user ID specified.

/times always returns the total items/pages.

Some things this would help support:
For a given user...

  • Total WRs
  • Total WRs by game
  • Total WRs by style
  • Displaying a list of WRs

...also can /maps/ return total pages? If I am given the total pages after making the first request, then I can make the rest of the requests I need at the same time. Otherwise, in order to load all the data I need, I have to wait for each page response and check if it's empty each time.

tl;dr: it would be very nice for most endpoints to return total pages/items

It would be very nice if /times/worldrecord supported returning the total items/pages in the response, particularly if a user ID specified. /times always returns the total items/pages. Some things this would help support: For a given user... * Total WRs * Total WRs by game * Total WRs by style * Displaying a list of WRs ...also can /maps/ return total pages? If I am given the total pages after making the first request, then I can make the rest of the requests I need at the same time. Otherwise, in order to load all the data I need, I have to wait for each page response and check if it's empty each time. tl;dr: it would be very nice for most endpoints to return total pages/items
itzaname commented 2025-06-29 04:06:12 +00:00
Owner
Copy Link

Yeah, all of them should show the full pagination like times does. Times has it since the existing internal API returned it but the others don't.

Yeah, all of them should show the full pagination like times does. Times has it since the existing internal API returned it but the others don't.
👍 2
itzaname added the Kind/Enhancement
Priority
Medium
3
 labels 2025-07-06 03:30:59 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label Kind/Enhancement
Priority
Medium
3
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
CI itzaname Quaternions
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: StrafesNET/public-api#4
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?