StrafesNET/protobufs
5
Fork 0
Code Issues 1 Pull Requests 1 Projects Releases Activity

Create Dedicated Validator Endpoints #8

Merged
Quaternions merged 11 commits from submissions into master 2025-07-18 04:09:47 +00:00
Conversation 0 Commits 11 Files Changed 1 +179
Quaternions commented 2025-07-18 03:40:20 +00:00
Owner
Copy Link

Replacing Maps Service openapi-internal.yaml With gRPC

These are all the endpoints used by the validator. The plan is to delete service_internal and create validator_controller with equivalent gRPC functionality. This can then be extended in the future for public api & maptest integration by creating new grpc endpoints that the public api & game-rpc talk to. The gRPC extensions would be separate files (mapfixes.proto, submissions.proto, maps.proto) unlike validator.proto which has a bunch of dedicated endpoints that only the validator should use.

Why?

To reduce the number of exposed apis. Without this there would need to be 4 (!) exposed apis (validator openapi, web openapi, public api, gRPC for game-rpc), with it, only 2 (web api, gRPC).

Why didn't you do this in the first place?

I didn't know how. I think I have a handle on it now.

### Replacing Maps Service `openapi-internal.yaml` With gRPC These are all the endpoints used by the validator. The plan is to delete `service_internal` and create `validator_controller` with equivalent gRPC functionality. This can then be extended in the future for public api & maptest integration by creating new grpc endpoints that the public api & game-rpc talk to. The gRPC extensions would be separate files (`mapfixes.proto`, `submissions.proto`, `maps.proto`) unlike `validator.proto` which has a bunch of dedicated endpoints that only the validator should use. ### Why? To reduce the number of exposed apis. Without this there would need to be 4 (!) exposed apis (validator openapi, web openapi, public api, gRPC for game-rpc), with it, only 2 (web api, gRPC). ### Why didn't you do this in the first place? I didn't know how. I think I have a handle on it now.
Quaternions added 7 commits 2025-07-18 03:40:20 +00:00
outline a2e45b5e9a
dedicated validator endpoints 60845ba8e1
validator: submissions cadfb1579d
validator: operations dde4825420
validator: type safety c9709874ab
validator: move operations f174d921e7
validator: scripts & script policies cea8134c26
Quaternions changed title from Replace Maps Service `openapi-internal.yaml` With gRPC to Create Dedicated Validator Endpoints 2025-07-18 03:58:21 +00:00
Quaternions added 1 commit 2025-07-18 04:01:55 +00:00
validator: type unsafety 5d4a213591
Quaternions added 2 commits 2025-07-18 04:06:23 +00:00
validator: fix numbers 55bf0f1f15
validator: script policy enum 15fd600612
Quaternions force-pushed submissions from 15fd600612 to 733dcd7a68 2025-07-18 04:07:04 +00:00 Compare
Quaternions merged commit 8f843ce8dc into master 2025-07-18 04:09:47 +00:00
Quaternions deleted branch submissions 2025-07-18 04:09:47 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
CI itzaname Quaternions
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: StrafesNET/protobufs#8
Delete Branch "submissions"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?