StrafesNET/protobufs
5
Fork 0
Code Issues Pull Requests Releases Activity

Remove Map ID filter (previously it was just 0) #3

Merged
Quaternions merged 1 commits from fix-mapfilter into master 2024-07-22 00:40:44 +00:00
Conversation 3 Commits 1 Files Changed 1 -1
Quaternions commented 2024-07-22 00:09:25 +00:00
Owner
Copy Link

ID is unused and unwanted for MapFilter.

ID is unused and unwanted for MapFilter.
Quaternions added 1 commit 2024-07-22 00:09:25 +00:00
itzaname commented 2024-07-22 00:15:30 +00:00
Owner
Copy Link

ID should just be removed as it's not an active filter item.

ID should just be removed as it's not an active filter item.
itzaname requested review from itzaname 2024-07-22 00:16:31 +00:00
Quaternions was assigned by itzaname 2024-07-22 00:16:37 +00:00
Quaternions force-pushed fix-mapfilter from b38e13a951 to 442e7724ed 2024-07-22 00:21:10 +00:00 Compare
Quaternions commented 2024-07-22 00:21:35 +00:00
Author
Owner
Copy Link

I like your idea better, I removed it

I like your idea better, I removed it
Quaternions changed title from Map ID should be an optional filter (previously it was just 0) to Remove Map ID filter (previously it was just 0) 2024-07-22 00:21:55 +00:00
itzaname requested changes 2024-07-22 00:24:01 +00:00
Dismissed
maps.proto Outdated
@ -42,3 +41,1 @@
optional string DisplayName = 2;
optional string Creator = 3;
optional int32 GameID = 4;
optional string DisplayName = 1;
itzaname commented 2024-07-22 00:22:31 +00:00
Owner
Copy Link

If you don't renumber it, it's backwards compatible with an older client/server.

If you don't renumber it, it's backwards compatible with an older client/server.
itzaname commented 2024-07-22 00:29:44 +00:00
Owner
Copy Link

Imagine commenting in the thread instead of the just the MR. 👎

Imagine commenting in the thread instead of the just the MR. 👎
Quaternions marked this conversation as resolved
Quaternions commented 2024-07-22 00:27:05 +00:00
Author
Owner
Copy Link

So the numbers do have a purpose

So the numbers do have a purpose
Quaternions force-pushed fix-mapfilter from 442e7724ed to debba86882 2024-07-22 00:27:56 +00:00 Compare
itzaname approved these changes 2024-07-22 00:31:47 +00:00
itzaname left a comment
Owner
Copy Link

LGTM

LGTM
Quaternions merged commit 2186c5cb96 into master 2024-07-22 00:40:44 +00:00
Quaternions deleted branch fix-mapfilter 2024-07-22 00:40:44 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
itzaname
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
Quaternions
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: StrafesNET/protobufs#3
No description provided.
Delete Branch "fix-mapfilter"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?