StrafesNET/maptest-bot
3
Fork 0
Code Issues Pull Requests Releases Activity

Parse map models and validate them #13

Merged
Quaternions merged 2 commits from parse-map-models into master 2024-04-24 06:28:08 +00:00
Conversation 1 Commits 2 Files Changed 8 +267 -45
fiveman1 commented 2024-04-24 05:18:30 +00:00
Collaborator
Copy Link

The enhancements:

  • Added map validation that checks for some common errors that maps have
  • /take: Does map validation but will still take the map even if there are problems
  • /take: Improved the help text and added links to the maptest places
  • /submit: Does map validation and will not let you submit if there are problems
  • /submissions: Now shows the map's display name and creator
  • Added an ESLint config and tidied some things up
  • Updated some of the packages
The enhancements: - Added map validation that checks for some common errors that maps have - /take: Does map validation but will still take the map even if there are problems - /take: Improved the help text and added links to the maptest places - /submit: Does map validation and will not let you submit if there are problems - /submissions: Now shows the map's display name and creator - Added an ESLint config and tidied some things up - Updated some of the packages
fiveman1 added 1 commit 2024-04-24 05:18:31 +00:00
dowoge commented 2024-04-24 05:21:16 +00:00
Member
Copy Link

THIS IS AWESOME

THIS IS AWESOME
Quaternions reviewed 2024-04-24 05:57:37 +00:00
common.js Outdated
@ -89,0 +166,4 @@
errors.push(`The root part of your model is a \`${root.ClassName}\`, it needs to be a \`Model\` instead.`);
}
else {
if ((game === "bhop" || game === "surf") && !root.Name.startsWith(game + "_")) {
Quaternions commented 2024-04-24 05:57:37 +00:00
Owner
Copy Link

This is not modular!

This is not modular!
Quaternions marked this conversation as resolved
fiveman1 added 1 commit 2024-04-24 06:23:34 +00:00
Quaternions merged commit 3a167cf686 into master 2024-04-24 06:28:08 +00:00
Quaternions deleted branch parse-map-models 2024-04-24 06:28:08 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: StrafesNET/maptest-bot#13
No description provided.
Delete Branch "parse-map-models"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?