From 37e691eebf355eaeccc8292d06ba223fefda8566 Mon Sep 17 00:00:00 2001 From: Carter Penterman Date: Tue, 27 Aug 2024 23:11:28 -0500 Subject: [PATCH] Update Noblox to 6.0.2 --- commands/submit.js | 5 +++-- commands/take.js | 5 +++-- common.js | 20 +------------------- package.json | 2 +- 4 files changed, 8 insertions(+), 24 deletions(-) diff --git a/commands/submit.js b/commands/submit.js index 0319970..9b31046 100644 --- a/commands/submit.js +++ b/commands/submit.js @@ -4,7 +4,7 @@ const fs = require('node:fs'); const noblox = require("noblox.js"); const axios = require("axios").default; const { submissions, commands, cookies } = require("../config/config.js"); -const { getAssetInfo, getCurrentUser, SubmissionColumnsString, createSubmissionLine, getSubmissionLine, validateMapAsset, getValidationMessage } = require("../common.js"); +const { getAssetInfo, SubmissionColumnsString, createSubmissionLine, getSubmissionLine, validateMapAsset, getValidationMessage } = require("../common.js"); async function robloxUserFromDiscord(id) { if (isNaN(id)) return undefined; @@ -52,7 +52,8 @@ async function execute(interaction) { try { // Check that the bot owns this model - if (!(await noblox.getOwnership(await getCurrentUser(), id, "Asset"))) { + const robloxUser = await noblox.getAuthenticatedUser(); + if (!(await noblox.getOwnership(robloxUser.id, id, "Asset"))) { const msg = `🚫 The ${game} maptest bot's inventory does not contain this asset (id: \`${id}\`). You must use the /take command first.`; await interaction.editReply(msg); return; diff --git a/commands/take.js b/commands/take.js index db322d7..5826d4a 100644 --- a/commands/take.js +++ b/commands/take.js @@ -1,7 +1,7 @@ const { SlashCommandBuilder } = require('@discordjs/builders'); const noblox = require("noblox.js"); const { cookies, commands, gamePlaces } = require("../config/config.js"); -const { getAssetInfo, buyModel, getCurrentUser, validateMapAsset, getValidationMessage } = require("../common.js"); +const { getAssetInfo, buyModel, validateMapAsset, getValidationMessage } = require("../common.js"); /** * @param {import('discord.js').ChatInputCommandInteraction} interaction @@ -20,7 +20,8 @@ async function execute(interaction) { let alreadyOwned; try { // Check if the bot already owns this asset - alreadyOwned = await noblox.getOwnership(await getCurrentUser(), id, "Asset"); + const robloxUser = await noblox.getAuthenticatedUser(); + alreadyOwned = await noblox.getOwnership(robloxUser.id, id, "Asset"); } catch (error) { if (error.message !== "400 The specified Asset does not exist!") { throw error; diff --git a/common.js b/common.js index 48389e1..856e0c4 100644 --- a/common.js +++ b/common.js @@ -90,24 +90,6 @@ async function buyModel(modelId) { return res.statusCode >= 200 && res.statusCode < 300 && resJson.purchaseTransactionStatus === "PURCHASE_TRANSACTION_STATUS_SUCCESS"; } -async function getCurrentUser() { - const jar = noblox.options.jar; - const xcsrf = await noblox.getGeneralToken(jar); - - const res = await noblox.http("https://users.roblox.com/v1/users/authenticated", { - method: "GET", - resolveWithFullResponse: true, - jar: jar, - headers: { - "X-CSRF-TOKEN": xcsrf, - "Content-Type": "application/json" - } - }); - - const resJson = JSON.parse(res.body); - return resJson.id; -} - const SubmissionColumnsString = "map_id,unix_timestamp,user_id,username,display_name,creator\n"; const SubmissionColumn = { @@ -366,4 +348,4 @@ function getValidationMessage(validation, game, errorOnFail) { return msg; } -module.exports = { AssetType, getAssetInfo, buyModel, getCurrentUser, SubmissionColumn, SubmissionColumnsString, getSubmissionLine, createSubmissionLine, validateMapAsset, getValidationMessage, safeCsvFormat }; \ No newline at end of file +module.exports = { AssetType, getAssetInfo, buyModel, SubmissionColumn, SubmissionColumnsString, getSubmissionLine, createSubmissionLine, validateMapAsset, getValidationMessage, safeCsvFormat }; \ No newline at end of file diff --git a/package.json b/package.json index 1f9e676..d6e01ca 100644 --- a/package.json +++ b/package.json @@ -6,7 +6,7 @@ "csv-parse": "^5.0.4", "discord-api-types": "^0.37.81", "discord.js": "^14.14.1", - "noblox.js": "^4.15.1", + "noblox.js": "^6.0.2", "node-csv": "^0.1.2", "rbxm-parser": "^1.1.0", "sugar-date": "^2.0.6"