From 4515eb6da24738b61b067675fab47faf09f4eaee Mon Sep 17 00:00:00 2001
From: Quaternions <krakow20@gmail.com>
Date: Fri, 28 Mar 2025 23:55:07 -0700
Subject: [PATCH 1/2] submissions: typo in error variable names
---
pkg/service/submissions.go | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/pkg/service/submissions.go b/pkg/service/submissions.go
index 1ecbc93..940d39f 100644
--- a/pkg/service/submissions.go
+++ b/pkg/service/submissions.go
@@ -48,8 +48,8 @@ var (
ErrAcceptOwnSubmission = fmt.Errorf("%w: You cannot accept your own submission as the submitter", ErrPermissionDenied)
ErrDelayReset = errors.New("Please give the validator at least 10 seconds to operate before attempting to reset the status")
ErrPermissionDeniedNotSubmitter = fmt.Errorf("%w: You must be the submitter to perform this action", ErrPermissionDenied)
- ErrPermissionDeniedNeedSubmissionRelease = fmt.Errorf("%w: Need Role SubmissionRelease", ErrPermissionDenied)
- ErrPermissionDeniedNeedSubmissionUpload = fmt.Errorf("%w: Need Role SubmissionUpload", ErrPermissionDenied)
+ ErrPermissionDeniedNeedRoleSubmissionRelease = fmt.Errorf("%w: Need Role SubmissionRelease", ErrPermissionDenied)
+ ErrPermissionDeniedNeedRoleSubmissionUpload = fmt.Errorf("%w: Need Role SubmissionUpload", ErrPermissionDenied)
ErrPermissionDeniedNeedRoleSubmissionReview = fmt.Errorf("%w: Need Role SubmissionReview", ErrPermissionDenied)
ErrPermissionDeniedNeedRoleMapDownload = fmt.Errorf("%w: Need Role MapDownload", ErrPermissionDenied)
ErrPermissionDeniedNeedRoleScriptWrite = fmt.Errorf("%w: Need Role ScriptWrite", ErrPermissionDenied)
@@ -393,7 +393,7 @@ func (svc *Service) ActionSubmissionTriggerUpload(ctx context.Context, params ap
}
// check if caller has required role
if !has_role {
- return ErrPermissionDeniedNeedSubmissionUpload
+ return ErrPermissionDeniedNeedRoleSubmissionUpload
}
// track who is performing the upload action
@@ -465,7 +465,7 @@ func (svc *Service) ActionSubmissionValidated(ctx context.Context, params api.Ac
}
// check if caller has required role
if !has_role {
- return ErrPermissionDeniedNeedSubmissionUpload
+ return ErrPermissionDeniedNeedRoleSubmissionUpload
}
// check when submission was updated
@@ -672,7 +672,7 @@ func (svc *Service) ReleaseSubmissions(ctx context.Context, request []api.Releas
}
// check if caller has required role
if !has_role {
- return ErrPermissionDeniedNeedSubmissionRelease
+ return ErrPermissionDeniedNeedRoleSubmissionRelease
}
idList := make([]int64, len(request))
--
2.47.1
From 92226e768d4f0c575956847aa82046aac1c27d70 Mon Sep 17 00:00:00 2001
From: Quaternions <krakow20@gmail.com>
Date: Fri, 28 Mar 2025 18:45:43 -0700
Subject: [PATCH 2/2] submissions: allow map council to upload maps
---
pkg/service/security.go | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pkg/service/security.go b/pkg/service/security.go
index 08e44e1..9584672 100644
--- a/pkg/service/security.go
+++ b/pkg/service/security.go
@@ -38,7 +38,7 @@ var (
RolesMapAdmin Roles = RolesSubmissionRelease|RolesSubmissionUpload|RolesSubmissionReview|RolesMapDownload
// has SubmissionReview
RoleMapCouncil GroupRole = 64
- RolesMapCouncil Roles = RolesSubmissionReview|RolesMapDownload
+ RolesMapCouncil Roles = RolesSubmissionReview|RolesSubmissionUpload|RolesMapDownload
// access to downloading maps
RoleMapAccess GroupRole = 32
RolesMapAccess Roles = RolesMapDownload
--
2.47.1