StrafesNET/maps-service
4
Fork 4
Code Issues 18 Pull Requests 1 Packages Projects Releases Wiki Activity

Group buttons and add confirmation dialogues #310

Merged
itzaname merged 5 commits from feature/review-buttons into staging 2025-12-28 00:34:58 +00:00
Conversation 9 Commits 5 Files Changed 1 +271 -74
itzaname commented 2025-12-27 23:59:02 +00:00
Owner
Copy Link

Reviewer:
image.png
Submitter:
image.png
image.png
Admin:
image.png
image.png

Confirmation Dialogue:
image.png

Example where both groups show up:
image.png

Reviewer: <img width="409" alt="image.png" src="attachments/a090c61e-a2d8-4685-ae64-547851d1ee84"> Submitter: <img width="404" alt="image.png" src="attachments/9205a438-1f1f-4af4-b9a0-6a8d56580afa"> <img width="411" alt="image.png" src="attachments/7ae8115b-3376-4306-b9b9-acc12226abb3"> Admin: <img width="392" alt="image.png" src="attachments/07a182d1-5375-4195-bfda-c14f09469cbe"> <img width="388" alt="image.png" src="attachments/ce82017d-5c1d-4a93-9247-9b5608f9030e"> Confirmation Dialogue: <img width="545" alt="image.png" src="attachments/1efff8be-1d41-429e-8c6e-3d36b7dad128"> Example where both groups show up: <img width="404" alt="image.png" src="attachments/b0ca4be2-7c58-4c0c-9a5f-dcd89e23b08f">
image.png
34 KiB
image.png
42 KiB
image.png
21 KiB
image.png
31 KiB
image.png
55 KiB
image.png
16 KiB
image.png
20 KiB
itzaname added the frontend label 2025-12-27 23:59:02 +00:00
itzaname added 2 commits 2025-12-27 23:59:02 +00:00
Add dialogues and better button groups 84e2ee5fdb
Remove tool tip and make descriptions agnostic to fix/submission
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
8e60e2b7d7
itzaname requested review from Quaternions 2025-12-27 23:59:02 +00:00
Quaternions commented 2025-12-28 00:09:46 +00:00
Owner
Copy Link

Note that the 'reset-*' endpoints are actually for catastrophic failure recovery and are inhibited after the action started for at least 10 seconds. Pressing them usually wreaks havoc if there was no failure.

Note that the 'reset-*' endpoints are actually for catastrophic failure recovery and are inhibited after the action started for at least 10 seconds. Pressing them usually wreaks havoc if there was no failure.
itzaname commented 2025-12-28 00:11:26 +00:00
Author
Owner
Copy Link

Note that the 'reset-*' endpoints are actually for catastrophic failure recovery and are inhibited after the action started for at least 10 seconds. Pressing them usually wreaks havoc if there was no failure.

Is this a request to rephrase them?

> Note that the 'reset-*' endpoints are actually for catastrophic failure recovery and are inhibited after the action started for at least 10 seconds. Pressing them usually wreaks havoc if there was no failure. Is this a request to rephrase them?
Quaternions requested changes 2025-12-28 00:15:37 +00:00
Dismissed
web/src/app/_components/review/ReviewButtons.tsx Outdated
@@ -36,0 +87,4 @@
name: "Request Changes",
action: "request-changes",
confirmTitle: "Request Changes",
confirmMessage: "This will return to the submitter and change the status to 'Changes Requested'.",
Quaternions commented 2025-12-28 00:05:37 +00:00
Owner
Copy Link

This wording is strange.
Suggestion:

Request that the submitter make changes.  Make sure you've explained which changes are requested in a comment.
This wording is strange. Suggestion: ``` Request that the submitter make changes. Make sure you've explained which changes are requested in a comment. ```
itzaname marked this conversation as resolved
itzaname added 1 commit 2025-12-28 00:17:02 +00:00
Change request msg
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
fc2fd529c2
itzaname requested review from Quaternions 2025-12-28 00:17:14 +00:00
Quaternions commented 2025-12-28 00:18:27 +00:00
Owner
Copy Link

Note that the 'reset-*' endpoints are actually for catastrophic failure recovery and are inhibited after the action started for at least 10 seconds. Pressing them usually wreaks havoc if there was no failure.

Is this a request to rephrase them?

Yes actually, I like the "Only press this if you're sure of X" wording from trigger-submit-unchecked. Something like "Only press this if you're sure the backend broke"

> > Note that the 'reset-*' endpoints are actually for catastrophic failure recovery and are inhibited after the action started for at least 10 seconds. Pressing them usually wreaks havoc if there was no failure. > > Is this a request to rephrase them? Yes actually, I like the "Only press this if you're sure of X" wording from trigger-submit-unchecked. Something like "Only press this if you're sure the backend broke"
itzaname added 1 commit 2025-12-28 00:24:27 +00:00
Make reset actions have scary warnings
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
7695feb193
Quaternions commented 2025-12-28 00:24:53 +00:00
Owner
Copy Link

Suggestions:
reset-submitting -> Only press this if you're sure the backend failed during submission. Returns to 'Under Construction' status.
reset-validation -> Only press this if you're sure the backend failed during validation. Returns to 'Script Review' status.
reset-uploading -> Only press this if you're sure the backend failed during upload. Returns to 'Validated' status.
reset-releasing -> Only press this if you're sure the backend failed during release. Returns to 'Uploaded' status.

Suggestions: reset-submitting -> Only press this if you're sure the backend failed during submission. Returns to 'Under Construction' status. reset-validation -> Only press this if you're sure the backend failed during validation. Returns to 'Script Review' status. reset-uploading -> Only press this if you're sure the backend failed during upload. Returns to 'Validated' status. reset-releasing -> Only press this if you're sure the backend failed during release. Returns to 'Uploaded' status.
itzaname commented 2025-12-28 00:24:56 +00:00
Author
Owner
Copy Link

Note that the 'reset-*' endpoints are actually for catastrophic failure recovery and are inhibited after the action started for at least 10 seconds. Pressing them usually wreaks havoc if there was no failure.

Is this a request to rephrase them?

Yes actually, I like the "Only press this if you're sure of X" wording from trigger-submit-unchecked. Something like "Only press this if you're sure the backend broke"

Updated with new scary text

> > > Note that the 'reset-*' endpoints are actually for catastrophic failure recovery and are inhibited after the action started for at least 10 seconds. Pressing them usually wreaks havoc if there was no failure. > > > > Is this a request to rephrase them? > > Yes actually, I like the "Only press this if you're sure of X" wording from trigger-submit-unchecked. Something like "Only press this if you're sure the backend broke" Updated with new scary text
Quaternions commented 2025-12-28 00:25:36 +00:00
Owner
Copy Link

Hell yeah long scary text

Hell yeah long scary text
Quaternions requested changes 2025-12-28 00:29:52 +00:00
Dismissed
web/src/app/_components/review/ReviewButtons.tsx Outdated
@@ -36,0 +26,4 @@
name: "Submit for Review",
action: "trigger-submit",
confirmTitle: "Submit for Review",
confirmMessage: "Are you ready to submit this for review? You can revoke it later if needed.",
Quaternions commented 2025-12-28 00:29:41 +00:00
Owner
Copy Link

Are you ready to submit this for review? The model version is locked in once submitted, but you can revoke it and click submit again if needed.

Are you ready to submit this for review? The model version is locked in once submitted, but you can revoke it and click submit again if needed.
itzaname marked this conversation as resolved
itzaname added 1 commit 2025-12-28 00:32:04 +00:00
Update submit
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
661b569075
Quaternions approved these changes 2025-12-28 00:34:22 +00:00
itzaname merged commit e41d34dd3d into staging 2025-12-28 00:34:58 +00:00
itzaname deleted branch feature/review-buttons 2025-12-28 00:34:58 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Quaternions
Labels
Clear labels
backend
Submissions api related
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 frontend
Website related
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 validator
Map validation related
 wontfix
This won't be fixed
No Label frontend
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aidan9382 CI dowoge ic3w0lf22 interpreterK itzaname Quaternions
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: StrafesNET/maps-service#310
Delete Branch "feature/review-buttons"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?