StrafesNET/maps-service
4
Fork 4
Code Issues 18 Pull Requests 1 Packages Projects Releases Wiki Activity

Cycle before and after images every 2 seconds #295

Merged
itzaname merged 4 commits from slideshow into staging 2025-12-27 05:26:04 +00:00
Conversation 3 Commits 4 Files Changed 1 +10 -29
Quaternions commented 2025-12-27 03:16:02 +00:00
Owner
Copy Link

The images should auto cycle now that the thumbnails are working.

I don't know how to test this! This is what I tried:

bun install
bun run build
VITE_API_HOST=https://maps.staging.strafes.net/v1 bun run preview

but the mapfixes page won't load the mapfixes.

The images should auto cycle now that the thumbnails are working. I don't know how to test this! This is what I tried: ``` bun install bun run build VITE_API_HOST=https://maps.staging.strafes.net/v1 bun run preview ``` but the mapfixes page won't load the mapfixes.
Quaternions added the enhancementfrontend labels 2025-12-27 03:16:02 +00:00
Quaternions self-assigned this 2025-12-27 03:16:02 +00:00
Quaternions added 1 commit 2025-12-27 03:16:02 +00:00
cycle before and after images every 1.5 seconds
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
fbd75ea1d3
Quaternions requested review from itzaname 2025-12-27 03:16:02 +00:00
itzaname commented 2025-12-27 04:46:20 +00:00
Owner
Copy Link

This makes the "click to compare" pointless so that should be removed if this is what the new way will be. Also 1.5 seconds is pretty quick and this looks pretty obnoxious.

This makes the "click to compare" pointless so that should be removed if this is what the new way will be. Also 1.5 seconds is pretty quick and this looks pretty obnoxious.
Quaternions added 2 commits 2025-12-27 04:52:25 +00:00
remove click to compare box 4d3374f837
increase cycle to 2s
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
cbf80af256
Quaternions commented 2025-12-27 04:55:48 +00:00
Author
Owner
Copy Link

This makes the "click to compare" pointless so that should be removed if this is what the new way will be.

Good catch, I never figured out how to test it so I didn't see what it looks like

Also 1.5 seconds is pretty quick and this looks pretty obnoxious.

It looks like I expected in your video, I'll make it a bit longer if you think so. I think auto-cycling this will help catch accidents where the wrong map is submitted or something better than needing to cycle it manually since people don't need to remember to do it.

> This makes the "click to compare" pointless so that should be removed if this is what the new way will be. Good catch, I never figured out how to test it so I didn't see what it looks like > Also 1.5 seconds is pretty quick and this looks pretty obnoxious. It looks like I expected in your video, I'll make it a bit longer if you think so. I think auto-cycling this will help catch accidents where the wrong map is submitted or something better than needing to cycle it manually since people don't need to remember to do it.
itzaname requested changes 2025-12-27 05:23:00 +00:00
Dismissed
web/src/app/mapfixes/[mapfixId]/page.tsx Outdated
@@ -121,6 +121,15 @@ export default function MapfixDetailsPage() {
};
// cycle before and after images every 1.5 seconds
itzaname commented 2025-12-27 05:22:56 +00:00
Owner
Copy Link

Comment outdated

Comment outdated
Quaternions marked this conversation as resolved
Quaternions added 1 commit 2025-12-27 05:24:23 +00:00
fix comment
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
87c2e3e07f
Quaternions requested review from itzaname 2025-12-27 05:24:28 +00:00
itzaname approved these changes 2025-12-27 05:25:47 +00:00
itzaname merged commit ea65794255 into staging 2025-12-27 05:26:04 +00:00
itzaname deleted branch slideshow 2025-12-27 05:26:04 +00:00
Quaternions changed title from Cycle before and after images every 1.5 seconds to Cycle before and after images every 2 seconds 2025-12-27 05:26:59 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
itzaname
Labels
Clear labels
backend
Submissions api related
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 frontend
Website related
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 validator
Map validation related
 wontfix
This won't be fixed
No Label enhancement frontend
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aidan9382 CI dowoge ic3w0lf22 interpreterK itzaname Quaternions
No Assignees Quaternions
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: StrafesNET/maps-service#295
Delete Branch "slideshow"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?