AOR / Review Process Integration #271
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: StrafesNET/maps-service#271
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Integration for the AOR and review process. All votes should be public:
Map admin will get the final verdict to decide based on the 2 polls.
I think it is important that feedback be available throughout the creation process, so that should be open even when the model hasn't been submitted. Since the mapper will (hopefully) be updating and addressing the given feedback, having a button for them to show they have addressed a piece of feedback or dissmiss it would be a good way of managing the feedback log, instead of having it clear whenver the map updates or is resubmitted.
Why does this "feedback" need to be separate from comments?
Because the map council feedback would be to show why we voted a certain way / why the map is or isnt fit to be in the game. Having a rejected map but all the feedback is randomly dispersed in comments that might not be relevant makes it harder for the mapper to look at their feedback. It also makes it clear where feedback is, and having the ability to address or dismiss the feedback will make it easier for the council to know when they should rereview a map.
I guess you could go about it by making it obvious within the comment box, like having a bright yellow map council tag on comments, but then it would show for all comments, and would mean feedback shows as regular comments and wouldnt be immediately available to the mapper, as well as no way for them to show that they have responded to the feedback without them directly contacting one of us.
Only map council and the map submitter are allowed to comment. This is effectively what comments are for. They can show they have responded to feedback by clicking submit again to put the map in submitted status.
Oh i thought comments were open to everyone. Since they are only map council and submitter its fine
The MVP is a new "Review" tab similar to comments where councillors will leave their vote along with their feedback. The model version they reviewed on is shown as well. Councillors can update the review at any time, and it will remove their old review and replace it with their new review. The votes will not update the status of the model.
I've split this into three parts: