StrafesNET/maps-service
4
Fork 4
Code Issues 20 Pull Requests 2 Packages Projects Releases Wiki Activity

De-monolithificate Services #236

Merged
Quaternions merged 32 commits from dedup into staging 2025-07-17 03:18:01 +00:00
Conversation 0 Commits 32 Files Changed 25 +1403 -768
Quaternions commented 2025-07-17 03:12:06 +00:00
Owner
Copy Link

Closes #204.

The branch is called dedup but the patch adds code...

  • Services both use an inner service that implements the underlying operations
  • Struct fields are made private, preventing code cross-contamination
  • Filter & Update structures are clearly defined, gaining clarity and type safety
Closes #204. The branch is called dedup but the patch adds code... - Services both use an inner service that implements the underlying operations - Struct fields are made private, preventing code cross-contamination - Filter & Update structures are clearly defined, gaining clarity and type safety
Quaternions added the backend label 2025-07-17 03:12:06 +00:00
Quaternions added 32 commits 2025-07-17 03:12:06 +00:00
submissions: create service_inner for common code fd0af4bc71
deduplicate audit events fb33420e75
type safe scripts 7929609372
scripts: return accurate error 45cde3cc65
scripts: deduplicate permissions check 3663c2f23a
script policy: use inner 24615b6673
maps: create inner faf013b8ea
maps: use inner
All checks were successful
continuous-integration/drone/push Build is passing
Details
e79b798dd8
operations: inner 1d172924fe
wip: mapfixes 7948879e0b
make inner service fields private 247bda4a02
make external service fields private 5096bc962d
move roblox to external service fbb936c07b
make internal service fields private e6dc4c65d4
nats for mapfixes 881f3a596d
mapfix completed 048fb4f3f6
wip: mapfixes: use inner
All checks were successful
continuous-integration/drone/push Build is passing
Details
8ddcf94829
write New instead of Make 55730f2eb0
rename MapRequest to MapUpdate 83e363c056
MapfixUpdate is distinct from MapfixFilter f05089b4b1
rewrite giant thing a9a39b5946
tough stuff 0fb04c3127
rewrite MapfixFilter
All checks were successful
continuous-integration/drone/push Build is passing
Details
6f9d93be6b
extend operations eef848250c
extend mapfixes 7951cc4d9c
mapfixes internal: use inner
All checks were successful
continuous-integration/drone/push Build is passing
Details
a69b1a7b5d
submissions inner c7491ff789
rename 79d6dc84d9
submissions nats fd280efde8
done
All checks were successful
continuous-integration/drone/push Build is passing
Details
af1d2c3798
rewrite map filter and update
All checks were successful
continuous-integration/drone/push Build is passing
Details
2095f28875
rewrite script & policy filter
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
0d9172cfd5
Quaternions merged commit 07e08af5ed into staging 2025-07-17 03:18:01 +00:00
Quaternions deleted branch dedup 2025-07-17 03:18:02 +00:00
Quaternions added this to the Maps Migration project 2025-07-22 14:15:57 +00:00
Quaternions moved this to Prerequisites in Maps Migration on 2025-07-26 04:58:36 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
backend
Submissions api related
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 frontend
Website related
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 validator
Map validation related
 wontfix
This won't be fixed
No Label backend
Milestone
No items
No Milestone
Projects
Clear projects
No project Maps Migration
Assignees
Clear assignees
aidan9382 CI dowoge ic3w0lf22 interpreterK itzaname Quaternions
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: StrafesNET/maps-service#236
Delete Branch "dedup"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?