StrafesNET/maps-service
4
Fork 4
Code Issues 23 Pull Requests 2 Packages Projects Releases Wiki Activity

Hide Irrelevant Submission Action Buttons #17

New Issue
Closed
opened 2025-03-25 00:16:55 +00:00 by Quaternions · 0 comments
Quaternions commented 2025-03-25 00:16:55 +00:00
Owner
Copy Link

Tracking this in an issue instead of letting it float in chat.

Submission action buttons should only be visible when the user has the required Role AND the submission is in the right status to perform the action.

Use the /api/session/roles endpoint to get the current user's roles.

Comment embed (note the scroll bar):

maps-service/web/src/app/submissions/[submissionId]/_reviewButtons.tsx Lines 49 to 61 in 3da4023466
// When is each button visible?
// Multiple buttons can be visible at once.
// Action | Role | When Current Status is One of:
// ---------------|-----------|-----------------------
// Submit | Submitter | UnderConstruction, ChangesRequested
// Revoke | Submitter | Submitted, ChangesRequested
// Accept | Reviewer | Submitted
// Validate | Reviewer | Accepted
// ResetValidating| Reviewer | Validating
// Reject | Reviewer | Submitted
// RequestChanges | Reviewer | Validated, Accepted, Submitted
// Upload | MapAdmin | Validated
// ResetUploading | MapAdmin | Uploading

Tracking this in an issue instead of letting it float in chat. Submission action buttons should only be visible when the user has the required Role AND the submission is in the right status to perform the action. Use the `/api/session/roles` endpoint to get the current user's roles. Comment embed (note the scroll bar): https://git.itzana.me/StrafesNET/maps-service/src/commit/3da4023466bb4d4d7b0e2d920d35222f2d310e70/web/src/app/submissions/%5BsubmissionId%5D/_reviewButtons.tsx#L49-L61
Quaternions changed title from Hide Irrelevant Submission Actions to Hide Irrelevant Submission Action Buttons 2025-03-25 00:18:14 +00:00
Quaternions added the frontend label 2025-03-25 00:18:21 +00:00
interpreterK was assigned by Quaternions 2025-03-25 01:05:36 +00:00
Quaternions added this to the 1.0 Release milestone 2025-03-29 05:27:08 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
backend
Submissions api related
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 frontend
Website related
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 validator
Map validation related
 wontfix
This won't be fixed
No Label frontend
Milestone
No items
No Milestone 1.0 Release
Projects
Clear projects
No project
Assignees
Clear assignees
aidan9382 CI dowoge ic3w0lf22 interpreterK itzaname Quaternions
No Assignees interpreterK
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: StrafesNET/maps-service#17
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?