StrafesNET/maps-service
4
Fork 4
Code Issues 23 Pull Requests 2 Packages Projects Releases Wiki Activity

API_HOST changes, thumbnail fix & cache, "list is empty" fix #150

Merged
ic3w0lf22 merged 4 commits from thumbnail-fix into staging 2025-06-03 23:54:13 +00:00
Conversation 6 Commits 4 Files Changed 6 +89 -64
ic3w0lf22 commented 2025-06-03 22:40:16 +00:00
Member
Copy Link

API_HOST was replaced in order for thumbnail/any redirects to work properly, this also assumes the API will be at {BASE_URL}/api, assuming the reverse proxy causes issues with the way redirects were initially setup to work.

Also no more "Submissions list is empty." while it's loading.

API_HOST was replaced in order for thumbnail/any redirects to work properly, this also assumes the API will be at `{BASE_URL}/api`, assuming the reverse proxy causes issues with the way redirects were initially setup to work. Also no more "Submissions list is empty." while it's loading.
ic3w0lf22 added 1 commit 2025-06-03 22:40:16 +00:00
API_HOST changes, thumbnail fix & cache, "list is empty" fix
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
740e3c8932 
API_HOST was replaced in order for thumbnail/any redirects to work properly, this also assumes the API will be at `{BASE_URL}/api`, assuming the reverse proxy causes issues with the way redirects were initially setup to work.

Also no more "Submissions list is empty." while it's loading.
ic3w0lf22 commented 2025-06-03 22:46:22 +00:00
Author
Member
Copy Link

This API_HOST change is important, don't forget to change it to BASE_URL & remove the /api at the end.

This `API_HOST` change is important, don't forget to change it to `BASE_URL` & remove the `/api` at the end.
Quaternions commented 2025-06-03 23:15:04 +00:00
Owner
Copy Link

I cast

Closes #146

I cast Closes #146
🎉 1
Quaternions added 2 commits 2025-06-03 23:35:30 +00:00
env var name change requires deployment configuration change 954dbaeac6
use null instead of sentinel value
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
8ea5ee2d41
Quaternions approved these changes 2025-06-03 23:37:44 +00:00
Quaternions commented 2025-06-03 23:38:31 +00:00
Owner
Copy Link

I opted to use an optional type signature instead of a sentinel value of -1. Also changing API_HOST to BASE_URL would require a deployment configuration change.

I opted to use an optional type signature instead of a sentinel value of -1. Also changing API_HOST to BASE_URL would require a deployment configuration change.
ic3w0lf22 changed target branch from master to staging 2025-06-03 23:39:05 +00:00
Quaternions commented 2025-06-03 23:50:23 +00:00
Owner
Copy Link

LGTM, if you're happy with these changes go ahead and merge

LGTM, if you're happy with these changes go ahead and merge
ic3w0lf22 commented 2025-06-03 23:53:53 +00:00
Author
Member
Copy Link

Fine with me as long it works 👍

Fine with me as long it works 👍
ic3w0lf22 added 1 commit 2025-06-03 23:53:57 +00:00
Merge branch 'staging' into thumbnail-fix
All checks were successful
continuous-integration/drone/push Build is passing
Details
continuous-integration/drone/pr Build is passing
Details
32095296c2
ic3w0lf22 merged commit 81539a606c into staging 2025-06-03 23:54:13 +00:00
ic3w0lf22 deleted branch thumbnail-fix 2025-06-03 23:54:20 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Quaternions
Labels
Clear labels
backend
Submissions api related
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 frontend
Website related
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 validator
Map validation related
 wontfix
This won't be fixed
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aidan9382 CI dowoge ic3w0lf22 interpreterK itzaname Quaternions
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: StrafesNET/maps-service#150
Delete Branch "thumbnail-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?