StrafesNET/maps-service
4
Fork 4
Code Issues 18 Pull Requests 1 Packages Projects Releases Wiki Activity

Add a favicon (#141) #149

Merged
aidan9382 merged 1 commits from aidan9382/maps-service:favicon into staging 2025-06-03 23:16:39 +00:00
Conversation 3 Commits 1 Files Changed 1
aidan9382 commented 2025-06-03 21:45:43 +00:00
Member
Copy Link

Is this the proper way to do it? No clue
Is adding a <link rel="icon"> a required thing even though most browsers fetch the favicon anyways? No clue
Did it work in testing? Yes

If someone who actually knows how most of this works wants to judge this and correct me go ahead

Is this the proper way to do it? No clue Is adding a `<link rel="icon">` a required thing even though most browsers fetch the favicon anyways? No clue Did it work in testing? Yes If someone who actually knows how most of this works wants to judge this and correct me go ahead
aidan9382 added the frontend label 2025-06-03 21:45:43 +00:00
aidan9382 added 1 commit 2025-06-03 21:45:44 +00:00
Add a favicon (#141) 4f31f8c75a
Quaternions commented 2025-06-03 23:13:17 +00:00
Owner
Copy Link

Here's the magic words:

Closes #141

Here's the magic words: Closes #141
Quaternions approved these changes 2025-06-03 23:14:02 +00:00
aidan9382 changed target branch from master to staging 2025-06-03 23:14:33 +00:00
aidan9382 commented 2025-06-03 23:14:50 +00:00
Author
Member
Copy Link

repointed to staging instead of master oops

repointed to staging instead of master oops
aidan9382 merged commit 5b7efa2426 into staging 2025-06-03 23:16:39 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Quaternions
Labels
Clear labels
backend
Submissions api related
 bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 frontend
Website related
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 validator
Map validation related
 wontfix
This won't be fixed
No Label frontend
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
aidan9382 CI dowoge ic3w0lf22 interpreterK itzaname Quaternions
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: StrafesNET/maps-service#149
Delete Branch "aidan9382/maps-service:favicon"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?