StrafesNET/maps-service
4
Fork 3
Code Issues20 Pull Requests2 Packages Projects Releases Wiki Activity

web: introduce Force Submit button

Browse Source
This commit is contained in:
Quaternions
2025-06-04 17:23:59 -07:00
parent 489a8c9c10
commit 80f30d20fa
2 changed files with 7 additions and 0 deletions
web/src/app
mapfixes
[mapfixId]
_reviewButtons.tsx
submissions
[submissionId]
_reviewButtons.tsx

5
web/src/app/mapfixes/[mapfixId]/_reviewButtons.tsx

@ -10,6 +10,7 @@ interface ReviewAction {
const ReviewActions = { const ReviewActions = {
Submit: {name:"Submit",action:"trigger-submit"} as ReviewAction, Submit: {name:"Submit",action:"trigger-submit"} as ReviewAction,
BypassSubmit: {name:"Bypass Submit",action:"bypass-submit"} as ReviewAction,
ResetSubmitting: {name:"Reset Submitting (fix softlocked status)",action:"reset-submitting"} as ReviewAction, ResetSubmitting: {name:"Reset Submitting (fix softlocked status)",action:"reset-submitting"} as ReviewAction,
Revoke: {name:"Revoke",action:"revoke"} as ReviewAction, Revoke: {name:"Revoke",action:"revoke"} as ReviewAction,
Accept: {name:"Accept",action:"trigger-validate"} as ReviewAction, Accept: {name:"Accept",action:"trigger-validate"} as ReviewAction,
@ -119,6 +120,10 @@ export default function ReviewButtons(props: ReviewId) {
} }
if (roles&RolesConstants.MapfixReview) { if (roles&RolesConstants.MapfixReview) {
// you can force submit a map in ChangesRequested status
if (!is_submitter && mapfixStatus === MapfixStatus.ChangesRequested) {
visibleButtons.push({ action: ReviewActions.BypassSubmit, color: "error", mapfixId });
}
// you can't review your own mapfix! // you can't review your own mapfix!
// note that this means there needs to be more than one person with MapfixReview // note that this means there needs to be more than one person with MapfixReview
if (!is_submitter && mapfixStatus === MapfixStatus.Submitted) { if (!is_submitter && mapfixStatus === MapfixStatus.Submitted) {

2
web/src/app/submissions/[submissionId]/_reviewButtons.tsx

@ -11,6 +11,7 @@ interface ReviewAction {
const ReviewActions = { const ReviewActions = {
Submit: {name:"Submit",action:"trigger-submit"} as ReviewAction, Submit: {name:"Submit",action:"trigger-submit"} as ReviewAction,
AdminSubmit: {name:"Admin Submit",action:"trigger-submit"} as ReviewAction, AdminSubmit: {name:"Admin Submit",action:"trigger-submit"} as ReviewAction,
BypassSubmit: {name:"Bypass Submit",action:"bypass-submit"} as ReviewAction,
ResetSubmitting: {name:"Reset Submitting (fix softlocked status)",action:"reset-submitting"} as ReviewAction, ResetSubmitting: {name:"Reset Submitting (fix softlocked status)",action:"reset-submitting"} as ReviewAction,
Revoke: {name:"Revoke",action:"revoke"} as ReviewAction, Revoke: {name:"Revoke",action:"revoke"} as ReviewAction,
Accept: {name:"Accept",action:"trigger-validate"} as ReviewAction, Accept: {name:"Accept",action:"trigger-validate"} as ReviewAction,
@ -123,6 +124,7 @@ export default function ReviewButtons(props: ReviewId) {
// you can force submit a map in ChangesRequested status // you can force submit a map in ChangesRequested status
if (!is_submitter && submissionStatus === SubmissionStatus.ChangesRequested) { if (!is_submitter && submissionStatus === SubmissionStatus.ChangesRequested) {
visibleButtons.push({ action: ReviewActions.AdminSubmit, color: "error", submissionId }); visibleButtons.push({ action: ReviewActions.AdminSubmit, color: "error", submissionId });
visibleButtons.push({ action: ReviewActions.BypassSubmit, color: "error", submissionId });
} }
// you can't review your own submission! // you can't review your own submission!
// note that this means there needs to be more than one person with SubmissionReview // note that this means there needs to be more than one person with SubmissionReview