From 218a7fbf0f0f2d77615f8b88d519e9811cd347d9 Mon Sep 17 00:00:00 2001
From: Quaternions <krakow20@gmail.com>
Date: Thu, 3 Oct 2024 12:25:39 -0700
Subject: [PATCH] more general PartialEq + PartialOrd

---
 ratio_ops/src/ratio.rs | 30 ++++++++++++++++++------------
 1 file changed, 18 insertions(+), 12 deletions(-)

diff --git a/ratio_ops/src/ratio.rs b/ratio_ops/src/ratio.rs
index b41dc74..a525b71 100644
--- a/ratio_ops/src/ratio.rs
+++ b/ratio_ops/src/ratio.rs
@@ -251,15 +251,18 @@ impl_ratio_assign_operator!(RemAssign,rem_assign);
 // Only implement PartialEq<Self>
 // Rust's operators aren't actually that good
 
-impl<Num,Den,T> PartialEq for Ratio<Num,Den>
+impl<LhsNum,LhsDen,RhsNum,RhsDen,T,U> PartialEq<Ratio<RhsNum,RhsDen>> for Ratio<LhsNum,LhsDen>
 	where
-		Num:Copy,
-		Den:Copy,
-		Num:core::ops::Mul<Den,Output=T>,
-		T:PartialEq,
+		LhsNum:Copy,
+		LhsDen:Copy,
+		RhsNum:Copy,
+		RhsDen:Copy,
+		LhsNum:core::ops::Mul<RhsDen,Output=T>,
+		RhsNum:core::ops::Mul<LhsDen,Output=U>,
+		T:PartialEq<U>,
 {
 	#[inline]
-	fn eq(&self,&other:&Self)->bool{
+	fn eq(&self,other:&Ratio<RhsNum,RhsDen>)->bool{
 		(self.num*other.den).eq(&(other.num*self.den))
 	}
 }
@@ -268,15 +271,18 @@ impl<Num,Den> Eq for Ratio<Num,Den>
 		Ratio<Num,Den>:PartialEq,
 {}
 
-impl<Num,Den,T> PartialOrd for Ratio<Num,Den>
+impl<LhsNum,LhsDen,RhsNum,RhsDen,T,U> PartialOrd<Ratio<RhsNum,RhsDen>> for Ratio<LhsNum,LhsDen>
 	where
-		Num:Copy,
-		Den:Copy,
-		Num:core::ops::Mul<Den,Output=T>,
-		T:PartialOrd,
+		LhsNum:Copy,
+		LhsDen:Copy,
+		RhsNum:Copy,
+		RhsDen:Copy,
+		LhsNum:core::ops::Mul<RhsDen,Output=T>,
+		RhsNum:core::ops::Mul<LhsDen,Output=U>,
+		T:PartialOrd<U>,
 {
 	#[inline]
-	fn partial_cmp(&self,&other:&Self)->Option<core::cmp::Ordering>{
+	fn partial_cmp(&self,other:&Ratio<RhsNum,RhsDen>)->Option<core::cmp::Ordering>{
 		(self.num*other.den).partial_cmp(&(other.num*self.den))
 	}
 }