StrafesNET/common
3
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

use Copy instead of unsafe

Browse Source
This commit is contained in:
Quaternions 2024-07-31 15:56:32 -07:00
parent 91608d5100
commit b5b20e0dba
1 changed files with 10 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
src/run.rs
View File

@ -79,22 +79,16 @@ impl Run{
} }
} }
pub fn finish(&mut self,time:Time)->Result<(),Error>{ pub fn finish(&mut self,time:Time)->Result<(),Error>{
//code based on std::mem::replace //this uses Copy
let dest=&mut self.state; match &self.state{
//let's ignore ownership rules for a moment RunState::Created=>Err(Error::NotStarted),
unsafe{ RunState::Started{timer}=>{
let state=std::ptr::read(dest); self.state=RunState::Finished{
match state{ timer:timer.pause(time),
RunState::Created=>Err(Error::NotStarted), };
RunState::Started{timer}=>{ Ok(())
let src=RunState::Finished{ },
timer:timer.pause(time), RunState::Finished{..}=>Err(Error::AlreadyFinished),
};
std::ptr::write(dest,src);
Ok(())
},
RunState::Finished{..}=>Err(Error::AlreadyFinished),
}
} }
} }
pub fn flag(&mut self,flag_reason:FlagReason){ pub fn flag(&mut self,flag_reason:FlagReason){